From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 18ADF6EC5D; Thu, 8 Apr 2021 10:40:09 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 18ADF6EC5D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617867609; bh=S+4JSaboRwR2gRkjJJ0UxuVusONvVZg6bTv/1hqBYkI=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=GqwpDnCD3ypFk3+8hESvFfHFB692yv4YsJRY5okFIWx0hUL1g1ZgSCRCVZ+ssNutc NeIhAWI92TtJhbKujwGCbJoSrpIruXd7syvsLds9u94vl9O5KqePKY8RlEy517SiFA /YJeQkMaF3C2aTDyWyCs/2LVnenc0kB1bw0QA00U= Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 7916C6EC5D for ; Thu, 8 Apr 2021 10:40:07 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7916C6EC5D Received: by mail-lj1-f177.google.com with SMTP id u4so1113133ljo.6 for ; Thu, 08 Apr 2021 00:40:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=kdu5jl1XKQ3psunLyxkn7Xfhq1GlyOmxJV49BRNDIrc=; b=jmhgZPYIfHjDGUhoz1EavWVxGaLwJDrq98BW57wunDHtXGtvd3VcHRaSRTJM8BmeFu XGeNuE6KyXOT0Ygmj8d+pEgWX4hKDa760/4dvt4ObtKQVL01zbXJfxhPk9qZur82inys BSbo63RSI+oxjapLviNYCVMxyRRhctDRvy0hXh3NpROYeCiPTR27mkAdSaGgLdddB5/k TLEIm1z72AWthhFloVmU/7KpiyRiFC0E/I2TJu+8ui65gF/HI8AYlWowW5bs8Pug/c8s Dsx9G8ht7eJedHkBj6wS/Ypc+iegzv+3V1L5gWeb+fQ0mk0+x4/MVkaT1yjOtdCJZorf uVkA== X-Gm-Message-State: AOAM5339kaWxw6cOVLGOlZK2rwXejWWWss+dMhRNXuEv/K0XTEnhraVD RxMJocC5IhwmqxoJvCw/DcpMnak8vds= X-Google-Smtp-Source: ABdhPJxTpaoQoVF+eyxzbVy4vkYrns+m1eib+Jmi83tkD6BJcfbgIwujjBup9MmLow9ydxh6ekE/zQ== X-Received: by 2002:a2e:89d0:: with SMTP id c16mr4706726ljk.450.1617867606247; Thu, 08 Apr 2021 00:40:06 -0700 (PDT) Received: from grain.localdomain ([5.18.199.94]) by smtp.gmail.com with ESMTPSA id v11sm2750912ljp.63.2021.04.08.00.40.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Apr 2021 00:40:04 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id 783E456015C; Thu, 8 Apr 2021 10:40:03 +0300 (MSK) Date: Thu, 8 Apr 2021 10:40:03 +0300 To: Serge Petrenko Cc: tml , Vladislav Shpilevoy Message-ID: References: <20210405155823.1121042-1-gorcunov@gmail.com> <0661429d-3059-00ff-d2ea-89a06c99f117@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0661429d-3059-00ff-d2ea-89a06c99f117@tarantool.org> User-Agent: Mutt/2.0.5 (2021-01-21) Subject: Re: [Tarantool-patches] [PATCH v3] qsync: provide box.info interface for monitoring X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Thu, Apr 08, 2021 at 10:34:56AM +0300, Serge Petrenko wrote: > > +static int > > +lbox_info_synchro(struct lua_State *L) > > +{ > > + lua_newtable(L); > > Maybe change to lua_createtable(L, 0, 2) ? > This will be consistent with what is done below, and lua doc > states that'll be a bit faster: > https://www.lua.org/manual/5.3/manual.html#lua_newtable > (sorry, a direct link to lua_createtable didn't work) Sure! Thanks!