From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 366566EC5D; Thu, 8 Apr 2021 10:11:38 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 366566EC5D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617865898; bh=GRG7FcL0TmaS5Jm9JYT8PlGwm9a75p0H9Dp5URg6Hv4=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=im/F+FeZdNGKnGE6KxDf7OYy4hXuPPFwfoxsZzbuQNK32HuYYkmTlepdaoRX01gft bPI2oSaa0sTUm+D8itBF5rgH/54Av3DI3TDNdP4RHegawV8f32FGK/D2juzqz1nyN9 FUz3LlinVQx9JD449JM/B4z3ayKcUd8ODgGUzWcE= Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 373DB6EC5D for ; Thu, 8 Apr 2021 10:11:36 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 373DB6EC5D Received: by mail-lf1-f47.google.com with SMTP id v140so2244878lfa.4 for ; Thu, 08 Apr 2021 00:11:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=mWHa7Mo/yxPJN+d1hNnlEdDlUFCiKhUu/dSXAxQo6G4=; b=jbT899QMiZUbKP0hd6JImqe+Pte7SAbAULYlySlsmGZoRF2vjyJ2zvAMXXN3yjMbUz VVIHkvAQdP2tkWkDE5r7jIP0wTJ2mRDtQHevi990LRlBQ2oDhThus5y3GucFyqA87dNl n56rs+RP4Vck7tHc0SXUiLKBTdwRPxo3fnBPG0/OtGRr02yqkEbKIrQcncliVLbmZj42 Rqqpw0sMCUFUwVa8/rzPB1azAfPn0Vkub4IN7jrC3fRZg3hv/frt56lR+u2tqHqupYQf ML95XRGpDCodLT/sfFAnBLZDyx5Oxq/zgFun1RWnouImrgZQe25tX8ZX36iJcKGFtaSv ki8g== X-Gm-Message-State: AOAM530DObJdeJTEUg7b201iB/5IlBA93tI2IdUbR9DFi3XVebEUe8BL vMbWkA1Adrvg+zPEpPYKdD2JgVvfyjg= X-Google-Smtp-Source: ABdhPJy2KpHm9cFx5Jhww7ahs2wPqfQvdcUhoxnNnMI/0NhJhmfpjA7LTlYFZmbBE4uppoCrN0AX8Q== X-Received: by 2002:a05:6512:321a:: with SMTP id d26mr5064618lfe.353.1617865895022; Thu, 08 Apr 2021 00:11:35 -0700 (PDT) Received: from grain.localdomain ([5.18.199.94]) by smtp.gmail.com with ESMTPSA id f10sm2732130lfh.61.2021.04.08.00.11.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Apr 2021 00:11:33 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id F088F56015C; Thu, 8 Apr 2021 10:11:32 +0300 (MSK) Date: Thu, 8 Apr 2021 10:11:32 +0300 To: Vladislav Shpilevoy Cc: tml Message-ID: References: <20210405155823.1121042-1-gorcunov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.0.5 (2021-01-21) Subject: Re: [Tarantool-patches] [PATCH v2] qsync: provide box.info interface for monitoring X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Thu, Apr 08, 2021 at 12:52:48AM +0200, Vladislav Shpilevoy wrote: > On 07.04.2021 23:15, Cyrill Gorcunov wrote: > > On Wed, Apr 07, 2021 at 10:53:27PM +0200, Vladislav Shpilevoy wrote: > >> Hi! Thanks for the patch! > >> > >> See 7 comments below. > >> > >>> qsync: provide box.info interface for monitoring > >>> > >>> Since commit 14fa5fd82 we support symbolic evaluation of > >> > >> 1. Please, after a commit hash provide the referenced commit > >> title in parentheses and quotes. > >> https://github.com/tarantool/tarantool/wiki/Code-review-procedure#commit-message > > > > Maybe worth to add an example then? Something like > > There is an example, see the link above. There is a result example but no any hints on how to generate it. I added to the page an example of use `git log --pretty=format ...`.