From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 30FFE6EC5D; Thu, 8 Apr 2021 00:15:10 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 30FFE6EC5D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617830110; bh=1pgX2hWKhSkYf7kXPQ7WElqUjmc2zXeqDrfDgbkZOig=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=m+mKRw42d4cfNE5u6vqUp/Qp995aLtcrGNhjdKZXMsrZYEdZI/yX3rYqbkGMnknLP YJUkdSWxgr+OvRjG5a0ogWQxF87SRl0xghp2gva2qzIYCrn0TDzA5sZyNm8+dwfcot t4raK9Pc4r/+mNYmqNQjmvJ7n10zQpiC5OpxitAg= Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D16796EC5D for ; Thu, 8 Apr 2021 00:15:08 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D16796EC5D Received: by mail-lf1-f50.google.com with SMTP id n138so392385lfa.3 for ; Wed, 07 Apr 2021 14:15:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=qHZrU+OM4iVR1o8VUSfCo2Mi47+W6KQlacXdP8uFcIQ=; b=QtATrSiHCMn5sUh21vGleNkK5+kDPtvfq7ryZiGPOtdJnNTQgmVlwZ+aDUqWAC+Ik2 Ig6gWZaiJbRYjtNluREqlStrxcQzDLqfZDK1CtEqrNkT8gskQZ5LdH+YGWemrxvGA34/ 8lVu/kRZEfVrOPLjuJZAqXjoDnjkS+EYELBEJevMn2Du0hl9SAU9sqMjE8OyOpqcwU53 QG5ML6yFBqbG+QLOpV+qXJmXiBvRRdHkXyu4phDg6yrg/nY5wWtxCfrxi2DHDmLMM7G4 N/icOe7MPz958yoamL3imkI1wtzFBQzzeMk3QAJ4nHM+/ZE/T3gLb1NI+VFCuSlaNGVS 2l/w== X-Gm-Message-State: AOAM531NfaSEb0iRxDKcufLor+H1579LJS1ubX/hadtSM56A8eO0rjkX HWu2eGxdG3xWTwN/HiG//Llj1NfZY00= X-Google-Smtp-Source: ABdhPJx9j9Y/kqyKWLuWSphAe/xJW2FclZbwlKVQOk7eH5Aeov8+3pqMczFVfnWPDI+wPbJbwO5pUw== X-Received: by 2002:ac2:58d1:: with SMTP id u17mr3828260lfo.440.1617830107810; Wed, 07 Apr 2021 14:15:07 -0700 (PDT) Received: from grain.localdomain ([5.18.199.94]) by smtp.gmail.com with ESMTPSA id m16sm2607816lfo.17.2021.04.07.14.15.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Apr 2021 14:15:06 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id 89BB9560149; Thu, 8 Apr 2021 00:15:05 +0300 (MSK) Date: Thu, 8 Apr 2021 00:15:05 +0300 To: Vladislav Shpilevoy Cc: tml Message-ID: References: <20210405155823.1121042-1-gorcunov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.0.5 (2021-01-21) Subject: Re: [Tarantool-patches] [PATCH v2] qsync: provide box.info interface for monitoring X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Wed, Apr 07, 2021 at 10:53:27PM +0200, Vladislav Shpilevoy wrote: > Hi! Thanks for the patch! > > See 7 comments below. > > > qsync: provide box.info interface for monitoring > > > > Since commit 14fa5fd82 we support symbolic evaluation of > > 1. Please, after a commit hash provide the referenced commit > title in parentheses and quotes. > https://github.com/tarantool/tarantool/wiki/Code-review-procedure#commit-message Maybe worth to add an example then? Something like [cyrill@grain tarantool.git] git log --pretty=reference -1 14fa5fd82 14fa5fd82 (cfg: support symbolic evaluation of replication_synchro_quorum, 2020-12-03) > > Thus we introduce the "synchro" leaf in box.info interface. > > For now only a few entries are printed out > > > > | tarantool> box.info.synchro > > | --- > > | - queue: > > | 1: > > | len: 0 > > | quorum: 1 > > | ... > > 2. AFAIK, it was decided not to return an array, and return only > the currently used queue. But even if it would be an array, as I > said in the previous review, the indexing must be by box.info.id, > not by any order. Assume there are multiple limbos, and the master is > not instance_id = 1. How is a user supposed to find what is the > queue in the currently used limbo? And what is the currently used > limbo? Wait, Vlad, this is v2, while I sent v3 already where tried to address the formatting https://lists.tarantool.org/tarantool-patches/YGt0TACA8xe6N7Rr@grain/ In short I use Thus we introduce the "synchro" leaf in box.info interface. For now only a few entries are printed out | tarantool> box.info.synchro | --- | - queue: | len: 0 | quorum: 1 | ... The `queue` represents limbo instance and `len` member shows the number of entries in the queue. Note that if we gonna support multiple queues then we might create a separate `queues` array to cover all possible instances. The `quorum` member shows the evaluated value of `replication_synchro_quorum` parameter. Your comments are still relevant and I'll address them in v4 but please make sure the output above is exactly what you prefer? > > Besides, the commit message and the docbot request are almost the > same. You could drop the message and leave only the docbot request > if you don't want to support both places. Also it would save time > on reading that, anyway the information is the same. I'll address all the rest of comments. Thanks for review! Cyrill