From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 24B496EC5D; Wed, 7 Apr 2021 22:58:50 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 24B496EC5D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617825530; bh=k5qh/5Mb/f2Bi4RnNzeeyrewdQlV0GbJSXVY3Mb9OVc=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Mf5jvf6cvg/Jo0BLSllX7TbjYH3cMlHZLAn8Zin92eMoTzAi5HR8ZC7P2AT6wceWE su/zxxKJhG3raJcyuqJIpxE/i7EErekIeYmGGPKu4a3vErzIpUOJ75HICshYeoNi3+ 0H192shdPAZTkIeVQIs9dZAdKFUqE+ncDr/9qHCY= Received: from smtp49.i.mail.ru (smtp49.i.mail.ru [94.100.177.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A957A6EC5D for ; Wed, 7 Apr 2021 22:58:49 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A957A6EC5D Received: by smtp49.i.mail.ru with esmtpa (envelope-from ) id 1lUEK8-0004dI-KM; Wed, 07 Apr 2021 22:58:49 +0300 Date: Wed, 7 Apr 2021 22:57:52 +0300 To: Igor Munkin Message-ID: References: <20210331192350.GK29703@tarantool.org> <20210406213716.GM29703@tarantool.org> <20210407161131.GN29703@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210407161131.GN29703@tarantool.org> X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD912A3E3D5D4B49FC1FEA0A53B931EDD909DE4D58F47F062C400894C459B0CD1B981AAAACDCF92904403D4165A75A023ABE0F89CAD3FD767EF97B3F93076A4A5D8 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F2393C4755A27B53EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637225475490A77DC518638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B2C41F91758E480055FE19ED75B94E434406708AB62ED68B8ED2E47CDBA5A96583C09775C1D3CA48CFCA5A41EBD8A3A0199FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C317B107DEF921CE79117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F79006377FC544C94ABA6E7D731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A50DCDE1573743694D04A189498CCA2B71F4F744C73144E8B1D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3454E98140CCACB5B39F55DB6432DBDDFD9BEBD505F50584FE1D6B57BB6286D174126409392F409C2B1D7E09C32AA3244C74BFF9BBA9FCA7596EE1058939B33585853296C06374E602FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioju+jaMfvANXr2p2VtwOM4zQ== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB42DBAD0522BCE0952FB8DF0691D1B3DAAEA74F72A545A057EF2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A89437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 23/30] test: disable PUC Lua test for fast function name X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Igor, On 07.04.21, Igor Munkin wrote: > Sergey, > > On 07.04.21, Sergey Kaplun wrote: > > Igor, > > > > > > > > > > > diff --git a/test/PUC-Lua-5.1-tests/errors.lua b/test/PUC-Lua-5.1-tests/errors.lua > > > > > > index cf24e40..af776a7 100644 > > > > > > --- a/test/PUC-Lua-5.1-tests/errors.lua > > > > > > +++ b/test/PUC-Lua-5.1-tests/errors.lua > > > > > > @@ -105,9 +105,13 @@ while 1 do > > > > > > insert(prefix, a) > > > > > > end]], "global 'insert'") > > > > > > > > > > > > -checkmessage([[ -- tail call > > > > > > - return math.sin("a") > > > > > > -]], "'sin'") > > > > > > +-- LuaJIT: Can't determine bytecode position for non Lua functions > > > > > > +-- (in particular for fast functions) and, therefore, detect fast > > > > > > +-- function names for errors in tail calls. > > > > > > > > > > This is kinda gibberish. I've tried the following snippets and can't > > > > > understand what do you mean by this comment. > > > > > > > > > > | $ luajit -e 'function q(a) return math.sin(a) end q("a")' > > > > > | luajit: (command line):1: bad argument #1 to 'q' (number expected, got string) > > > > > | stack traceback: > > > > > | [C]: in function 'q' > > > > > | (command line):1: in main chunk > > > > > | [C]: at 0x5610e8497eb0 > > > > > | $ luajit -e 'loadstring("return math.sin([[a]])")()' > > > > > | luajit: (command line):1: bad argument #1 to '?' (number expected, got string) > > > > > | stack traceback: > > > > > | [builtin#43]: at 0x7fc0f807ad10 > > > > > | (command line):1: in main chunk > > > > > | [C]: at 0x55c1e85c7eb0 > > > > > > > > > > I understand the first result. The second result surprised me, but I've > > > > > never investigated how loadstring call works (it looks like specifics of > > > > > VARG frame, but this is a wild guess). But neither of them fits your > > > > > explanation. The root cause is the same: callee uses caller frame, since > > > > > caller doesn't need it anymore. Could you please clarify yours? > > > > > > > > This is not about `loadstring()` at all: > > > > > > > > | luajit -e 'return math.sin"a"' > > > > | luajit: bad argument #1 to '?' (number expected, got string) > > > > | stack traceback: > > > > | [builtin#43]: at 0x7f7c2ca6dbe0 > > > > | [C]: at 0x558b0cd4cec0 > > > > > > > > The guest frame is looked like the following (when the error thrown): > > > > | 0x40001938 [ ] VALUE: string "number expected, got string" @ 0x40008380 > > > > | 0x40001930 [ B ] VALUE: string "a" @ 0x40008250 > > > > | 0x40001928 [ ] FRAME: [CP] delta=3, fast function #44 > > > > > > > > When LuaJIT tries to detect function's name it determines bytecode > > > > position first, via `debug_framepc()`. But it can't determine bytecode > > > > position for non-Lua functions: > > > > > > What? Both luajit-gdb.py and LuaJIT itself reports the fast function ID > > > and this is its name. > > > > Yes, what is your question about? > > Then what's the problem with name resolving? As I said before for tailcall there is no creation of additional Lua frame. Without it guest frame is looks like the following: | 0x40001950 [ T ] | 0x40001948 [ ] VALUE: string "number expected, got string" @ 0x40008380 | 0x40001940 [ B ] VALUE: string "a" @ 0x40008280 | 0x40001938 [ ] FRAME: [LP] delta=1, fast function #44 | 0x40001930 [ ] FRAME: [V] delta=1, Lua function @ 0x40008248, 0 upvalues, "=(command line)":0 | 0x40001928 [ ] FRAME: [CP] delta=3, Lua function @ 0x40008248, 0 upvalues, "=(command line)":0 `err_argmsg()` function uses `lj_debug_funcname()`, which uses `debug_framepc()`, which can't get bcpos required for function prototype detection (see explanation with code sources above). So, LuaJIT can't detect fast function names for tailcalls on C frame. > > > > > > > > > > > > > > | if (!isluafunc(fn)) { /* Cannot derive a PC for non-Lua functions. */ > > > > | return NO_BCPOS; > > > > > > > > > > > > > > > +-- The test is disabled for LuaJIT. > > > > > > +-- checkmessage([[ -- tail call > > > > > > +-- return math.sin("a") > > > > > > +-- ]], "'sin'") > > > > > > > > > > > > checkmessage([[collectgarbage("nooption")]], "invalid option") > > > > > > > > > > > > > -- > > Best regards, > > Sergey Kaplun > > -- > Best regards, > IM -- Best regards, Sergey Kaplun