From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 84E0A6EC5D; Wed, 7 Apr 2021 19:07:29 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 84E0A6EC5D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617811649; bh=4FLSgTlpAhEkLEriWr+S8GMwbNqGv97oCZvYsqaUpOo=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=R74kqzySEJ1H7JsWDejziKg1pTCStL/BACTKU8PEAYXCeNjoT3oCxDedhaYgAlRFm s66MmCKzpVRY660ulY1DiAhyGBeg6mcshM+7risqcw7YT6JxMqWQs8fv5BwlVGl0ow eAAa/kzrT5Vjj0mSIx76EAo7WnoVSicnBBxjNhg0= Received: from smtp35.i.mail.ru (smtp35.i.mail.ru [94.100.177.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 87AB26EC5D for ; Wed, 7 Apr 2021 19:07:28 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 87AB26EC5D Received: by smtp35.i.mail.ru with esmtpa (envelope-from ) id 1lUAiF-00079o-Op; Wed, 07 Apr 2021 19:07:28 +0300 Date: Wed, 7 Apr 2021 19:06:32 +0300 To: Igor Munkin Message-ID: References: <20210331192350.GK29703@tarantool.org> <20210406213716.GM29703@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210406213716.GM29703@tarantool.org> X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD912A3E3D5D4B49FC171AADCC0319DEE4F527435CB409D56B200894C459B0CD1B9867502E8D9651279AB5B56265EA11EBD2D46EDF198B397D65E6CE7239E2C5700 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7081BBE264C6D7F42EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637C5BAFDCCAC60DA968638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B2A7BCD38D3DA1549ACBD5036E288BF87239A77D2A56A56FF9D2E47CDBA5A96583C09775C1D3CA48CF17B107DEF921CE79117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE77A825AB47F0FC8649FA2833FD35BB23DF004C906525384302BEBFE083D3B9BA71A620F70A64A45A98AA50765F79006372E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89FAE2BFB9A60527F4F35872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A51DC4BB1DE675B462E6A54996DF0A2A2B17E70A5EA4BB4A38D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34B3611847B8BC2D0BCDD3AF6BA2C38B3561C3E107B7F2AF84C2B61CE01E8180280F769DE5CA5DBF721D7E09C32AA3244CEC9376C11A23B1B8DC89C14A3A63B70D8894E9C85370243EFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioju+jaMfvANXqIXeFZ7++cGw== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB4BB7F8C8A0DC12DD5D187B6FEC6798FB3593E713CE1F2C49AF2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A89437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 23/30] test: disable PUC Lua test for fast function name X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Igor, On 07.04.21, Igor Munkin wrote: > Sergey, > > On 02.04.21, Sergey Kaplun wrote: > > Igor, > > > > Thanks for the review! > > > > On 31.03.21, Igor Munkin wrote: > > > Sergey, > > > > > > Thanks for the patch! Please consider the comments below. > > > > > > On 26.03.21, Sergey Kaplun wrote: > > > > LuaJIT can't determine bytecode position for non Lua functions > > > > (in particular for fast functions) and, therefore, detect built-in > > > > function names for errors in tail calls. > > > > > > Side note: here is the inconsistency in your usage of possessive nouns. > > > > Fixed. > > No, it's not, but this doesn't bother me anymore. Why? Please expalin where I'm wrong. > > > > > > > > > > diff --git a/test/PUC-Lua-5.1-tests/errors.lua b/test/PUC-Lua-5.1-tests/errors.lua > > > > index cf24e40..af776a7 100644 > > > > --- a/test/PUC-Lua-5.1-tests/errors.lua > > > > +++ b/test/PUC-Lua-5.1-tests/errors.lua > > > > @@ -105,9 +105,13 @@ while 1 do > > > > insert(prefix, a) > > > > end]], "global 'insert'") > > > > > > > > -checkmessage([[ -- tail call > > > > - return math.sin("a") > > > > -]], "'sin'") > > > > +-- LuaJIT: Can't determine bytecode position for non Lua functions > > > > +-- (in particular for fast functions) and, therefore, detect fast > > > > +-- function names for errors in tail calls. > > > > > > This is kinda gibberish. I've tried the following snippets and can't > > > understand what do you mean by this comment. > > > > > > | $ luajit -e 'function q(a) return math.sin(a) end q("a")' > > > | luajit: (command line):1: bad argument #1 to 'q' (number expected, got string) > > > | stack traceback: > > > | [C]: in function 'q' > > > | (command line):1: in main chunk > > > | [C]: at 0x5610e8497eb0 > > > | $ luajit -e 'loadstring("return math.sin([[a]])")()' > > > | luajit: (command line):1: bad argument #1 to '?' (number expected, got string) > > > | stack traceback: > > > | [builtin#43]: at 0x7fc0f807ad10 > > > | (command line):1: in main chunk > > > | [C]: at 0x55c1e85c7eb0 > > > > > > I understand the first result. The second result surprised me, but I've > > > never investigated how loadstring call works (it looks like specifics of > > > VARG frame, but this is a wild guess). But neither of them fits your > > > explanation. The root cause is the same: callee uses caller frame, since > > > caller doesn't need it anymore. Could you please clarify yours? > > > > This is not about `loadstring()` at all: > > > > | luajit -e 'return math.sin"a"' > > | luajit: bad argument #1 to '?' (number expected, got string) > > | stack traceback: > > | [builtin#43]: at 0x7f7c2ca6dbe0 > > | [C]: at 0x558b0cd4cec0 > > > > The guest frame is looked like the following (when the error thrown): > > | 0x40001938 [ ] VALUE: string "number expected, got string" @ 0x40008380 > > | 0x40001930 [ B ] VALUE: string "a" @ 0x40008250 > > | 0x40001928 [ ] FRAME: [CP] delta=3, fast function #44 > > > > When LuaJIT tries to detect function's name it determines bytecode > > position first, via `debug_framepc()`. But it can't determine bytecode > > position for non-Lua functions: > > What? Both luajit-gdb.py and LuaJIT itself reports the fast function ID > and this is its name. Yes, what is your question about? > > > > > | if (!isluafunc(fn)) { /* Cannot derive a PC for non-Lua functions. */ > > | return NO_BCPOS; > > > > > > > > > +-- The test is disabled for LuaJIT. > > > > +-- checkmessage([[ -- tail call > > > > +-- return math.sin("a") > > > > +-- ]], "'sin'") > > > > > > > > checkmessage([[collectgarbage("nooption")]], "invalid option") > > > > > > > > -- > > > > 2.31.0 > > > > > > > > > > -- > > > Best regards, > > > IM > > > > -- > > Best regards, > > Sergey Kaplun > > -- > Best regards, > IM -- Best regards, Sergey Kaplun