From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id AE9FD6FC8F; Thu, 25 Mar 2021 15:07:38 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org AE9FD6FC8F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1616674058; bh=Ib+C1ZrrhJjFW2BHHx3xuUCvUynXKu+YHcG2NZLLXoc=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=lrRq34eE7dFqV5PZxaA+/b0OS/hvnEFFOnStBD5U9NJVHXqLMYLcYmQ4hsB/LVv4p Isoaoli/A2VV0RYzTpSsXK3OjNmmv4VjuC/cmP0iFHmCLIgvwwOA39DldmACsenSX2 qVRg8w5xDxd3fQOwUxbqI9O+5TT6PmOSnD74yKu0= Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E8D776FC8F for ; Thu, 25 Mar 2021 15:07:37 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E8D776FC8F Received: by mail-lj1-f182.google.com with SMTP id r20so2800139ljk.4 for ; Thu, 25 Mar 2021 05:07:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=TkBpmCdhjERaNXTB3Bu1M5+lcMSTORMRTTJyCVw/FXk=; b=M9txthh+gkG7h4Lk8fWfnGmBlNvWyxf8TusUnsOEq3HTQZyjgnel93+usQUi39TxYN qIJmWJlHIVTt3JIirm4bPKCtI+5Y16oM5slBXDPAiEnfGkFa7ZznCD63PecWTM43ukBG x/57bvG58+E64ETa87DxLI0od6C5Psr5vvEm4si91vlv8iZUOcc8SVX+2rUTDLPVHdcF cTSJyCtzpq82EsXCGrducUmGrWnwh4ePdDgV05iNRXV+ELUcobDaxxKr0gtdHUkP7RHo ZOj0WnPjmCSDktRAT7udie6a7JMcJ8jJVwInIkdIr7u8PKnFhPEajbNAVVlILZv8KIDr GUpA== X-Gm-Message-State: AOAM5310qwTpHT2/p/2t007mVKQ5i8lEakTa4aKmFNWlGJNqsg/teoQy KhzJEyKIBu7zez017MbXlaT/oqIrwPFdfw== X-Google-Smtp-Source: ABdhPJzIvhGfrCRfbg+5SJoln3oe3iobRVk1hgZ6FwwOldAfggUrKg/m1hrDkpX1HJsu8AN49GzX/g== X-Received: by 2002:a2e:8e28:: with SMTP id r8mr5620549ljk.156.1616674056896; Thu, 25 Mar 2021 05:07:36 -0700 (PDT) Received: from grain.localdomain ([5.18.171.94]) by smtp.gmail.com with ESMTPSA id b9sm535275lfo.237.2021.03.25.05.07.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Mar 2021 05:07:35 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id 0A14256017D; Thu, 25 Mar 2021 15:07:35 +0300 (MSK) Date: Thu, 25 Mar 2021 15:07:34 +0300 To: Vladislav Shpilevoy Message-ID: References: <20210324163759.1900553-1-gorcunov@gmail.com> <20210324163759.1900553-3-gorcunov@gmail.com> <4b25e784-84b8-0a5d-d48c-2a47eb939d09@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4b25e784-84b8-0a5d-d48c-2a47eb939d09@tarantool.org> User-Agent: Mutt/2.0.5 (2021-01-21) Subject: Re: [Tarantool-patches] [PATCH v4 2/3] test: add a test for wal_cleanup_delay option X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Cc: tml Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Wed, Mar 24, 2021 at 11:10:23PM +0100, Vladislav Shpilevoy wrote: > Thanks for working on this! > > See 4 comments below. > > > + > > +-- > > +-- Stop the replica node and generate > > +-- xlogs on the master. > > +test_run:switch('default') > > 1. You could switch to the master right away. No > need to switch through the default node. No. I'm *on* the replica at this moment and then I need to stop it. I can't stop server being on it, otherwise we hang. Already tried. > > +test_run:switch('default') > > 2. You can restart the master without switching to default. Yes, thanks. And same for rest of comments, will update.