From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id F41256FC86; Mon, 22 Mar 2021 10:52:03 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org F41256FC86 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1616399524; bh=EIH+2RhEFbmKKO1xVUUenhurrkucL76obWU5qvK7gKA=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=UqmtNGCvxly8HSqq+YeAqkZX1PyXtUvuI0TFQgnSZNHQg7NaPbHeqzXjuqnqwBoAM 6eShj5JGzTm/DBwley+oMZQv2QkOHAKGLbLezrgve+olaXy2qslGEHnmSXo/Dw7Kzh 7fHB2Dn0ZRn0eqfjpJeuQGOQaMdUpzpD6n6ecINs= Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id BCE4E6FC86 for ; Mon, 22 Mar 2021 10:52:02 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BCE4E6FC86 Received: by mail-lf1-f50.google.com with SMTP id x28so19721061lfu.6 for ; Mon, 22 Mar 2021 00:52:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=w8HL3EhO0EF/HC1iWThK1Oc6/pvfQbtj60RFz9B2yeI=; b=t+1ziBcOJOYEM5SnnxkrM2pP3fZp8W0vxHfLTxVC2+kpF+01ABW70fDpamQoLSfBRV DIJ/jnYwoLDI+nOXy8SAFYnv816pbewbkRgFmfC0d5kORX1/rLZXrVuJSqMbHqdCSCGI OUw/lJbNzdd4vpyNK9D9eemaZWTbd6OVtDPypIibP3EOTiMUOiLmcJ3u6+luqWKBk6Gm Nbnalkhf+ZYh9UuslqYGvPW82gWLuwzuM79g01VeUUBExr8bfYDuuk27H8G888dj9Kd0 XsBhqGPu/AMmlP0CJx/xR+bCXA59pOQgOUssZBjf9HbyWpzebZxx4Qj7lRxHRVBcq9SC QQAQ== X-Gm-Message-State: AOAM531lcWBXBA9mjz6dLHsab2OcHFrXwMB1t6Mh6ou7HjiovRBUUHce /P51pJ2tIuoqiSCtf6Qh/hTpTli23vM= X-Google-Smtp-Source: ABdhPJzvtd2JqAQvkaLCyd98n5CRo8gb+c810peoiSDsn/SlbP0Glsw0nNeR3AWgsQdCGf2iiMJUjg== X-Received: by 2002:ac2:4a70:: with SMTP id q16mr8469530lfp.455.1616399521771; Mon, 22 Mar 2021 00:52:01 -0700 (PDT) Received: from grain.localdomain ([5.18.171.94]) by smtp.gmail.com with ESMTPSA id w14sm1476783lfl.305.2021.03.22.00.52.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Mar 2021 00:52:00 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id 3F69D560181; Mon, 22 Mar 2021 10:52:00 +0300 (MSK) Date: Mon, 22 Mar 2021 10:52:00 +0300 To: Vladislav Shpilevoy Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.0.5 (2021-01-21) Subject: Re: [Tarantool-patches] [PATCH 00/16] Cord buffer, static alloc, and Lua GC bug X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Sat, Mar 20, 2021 at 01:42:30AM +0100, Vladislav Shpilevoy wrote: > The patch attempts to fix most of the easy to face issues with the global > resources not having proper ownership in Lua code and therefore not protected > again being suddenly reused during Lua GC. > > There are many such resources: tarantool_lua_ibuf/IBUF_SHARED, static alloc, > errno, diag/box.error, box_tuple_last, port_c, and others. > > The most easy to screw - ibuf and static alloc. They are fixed in this > patchset. > > The solution is dubious, but there were not found any better alternatives. > > A patch for 1.10 will be sent later in a separate CL. > > Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-5632-global-buf-crash-2x > Issue: https://github.com/tarantool/tarantool/issues/5632 Vlad, the series look ok to me. But i think we need more intensive testing and catch up if there is some missed. Thus I propose to merge and get it a spin up while we have time.