From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 822E96FC86; Mon, 22 Mar 2021 10:35:23 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 822E96FC86 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1616398523; bh=09F4r67tzE/lz/XxA85X/VcFCsNyTKsLoUIALvEs/tM=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=pWFTMdJGFmCvrc9bSzW3JlklBn4T1whi9fKX1y62HVpYDOmJ+UGZ1EhP6ybCUhQs6 FtoQdze97MOfcCn2D8hAK0HTbvxLJ7ipRcjVCENwnqSTLkaBmG7YUuLFY5eqAmi/QL y/Hl25aQn6bBgCx7Y1hixYj9KjJa1AE7hWDdHsgM= Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 66CE46FC86 for ; Mon, 22 Mar 2021 10:35:22 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 66CE46FC86 Received: by mail-lj1-f179.google.com with SMTP id s17so19814363ljc.5 for ; Mon, 22 Mar 2021 00:35:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=XbFEuotv+YD1bWJcqF1hF7hK5QVBqLOAwsX8GTFh88k=; b=ckBH7Ca/9OqEtjm2bDhiUUKzFaLgq88dvcVbXSbTvbMKPvdtNUzVpyCuKYVccN36wt sBa3zAIQusSTXJNUEClM1a3ILokPvCgJaefG7WLKDPruVbMJiTee7xrTUyrsPr0Dz7yT 3S90luilajV2Go5p9DMgx9xa5vNA5btKToignNQCalf7k2Ac86qev6czWnPEo5uq4FJa KAMVDosUVykK1XJCesJhPE2FHtG1bZXj8sBjXNrhRLfF7zvtNx/PsOSbxFSXheAYuLp1 +dlWt9SQ7OXho1Ya5poU1p/RMCxGQGFryfe9iIKw+oavX2iZ9+J2AKc6nPXHXc6tGcPe R7rw== X-Gm-Message-State: AOAM532dK481haIN+1FEJYBC8RPcmnLIhMBtgFoWl2e6PFX2VUSjG+xb oCwAKoqJU4PAsxD0cRwyVBMLedg//B0= X-Google-Smtp-Source: ABdhPJzPtZnd9B6X5FDUA1nZceQ/CZstYfTmRQRaD4CM1NrVKV52UI6qjuQ0ZUEU7IObkqDsyvbNlw== X-Received: by 2002:a2e:700a:: with SMTP id l10mr8859581ljc.368.1616398521441; Mon, 22 Mar 2021 00:35:21 -0700 (PDT) Received: from grain.localdomain ([5.18.171.94]) by smtp.gmail.com with ESMTPSA id i22sm1844502ljg.37.2021.03.22.00.35.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Mar 2021 00:35:20 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id D16AB560181; Mon, 22 Mar 2021 10:35:17 +0300 (MSK) Date: Mon, 22 Mar 2021 10:35:17 +0300 To: Vladislav Shpilevoy Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.0.5 (2021-01-21) Subject: Re: [Tarantool-patches] [PATCH 02/16] test: don't use IBUF_SHARED in the tests X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Sat, Mar 20, 2021 at 01:42:39AM +0100, Vladislav Shpilevoy wrote: > In msgpack test it is used only to check that 'struct ibuf *' can > be passed to encode() functions. But soon IBUF_SHARED will be > deleted, and its alternative won't be yield-tolerant. This means > it can't be used in this test. There are yields between the buffer > usages. > > In varbinary test it is used in a too complicated way to be able > to put it back normally. And otherwise its usage does not make > much sense - without put() it is going to be created from the > scratch on non-first usage until a yield. > > In the module_api test it is used to check if some function works > with 'struct ibuf *'. Can be done without IBUF_SHARED. Ack