From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id A1E6E6FC86; Mon, 22 Mar 2021 00:58:31 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A1E6E6FC86 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1616363911; bh=dyngUDbLep1OEN0gPr8vNak6ZK3PuASA/xXZTZT/6AI=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=nBwnQ8k3wtpvZP14T6AAenQp3UARGR8ppEoHgSNCCwopkS5cEn1tgiHgBxZhoATs0 lu6TU/ahDXXx5j3bQNnHsLfZOk9Y+d4JeSqGGZTNwW3elMZYCP6xrMStM0upwVS0C2 k1VfOiQE5PH/ivbfKfGCdELYWjc0w19jAI5ldshE= Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 86D816FC86 for ; Mon, 22 Mar 2021 00:58:30 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 86D816FC86 Received: by mail-lf1-f52.google.com with SMTP id n138so18257784lfa.3 for ; Sun, 21 Mar 2021 14:58:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=b7AuGNdPWZbu0WiyEqY8dhgVjatzmdkylNwmmgr+G/U=; b=awjetSY+3DJBa8U7TUKgQS7W5FOAFrZbXrUCLgHiFSaBe8Y4TILOlic0h01OmEXAop Okr79lo2PpC5KIxGk6vE/8kQTuBWLuCNXim8IPrUmIVVYgQMTi8clMATSE77HxsJ/8eg 8qYFsKlE3GxS7OeJjyb07oihBeAqihiqp7COdCLvoR/UK0rJzrb18i4ljvCtE/mhbAS3 eQsj/D1jp+n9sobsQGUZqWCxFbPIXR0Atq/9yeXlVnoZv9MBMbhlwAHhTWioiM0x4YTG bTCnShYmRrpH8qhFnSBfB4c8PWhg+NXbCGRwL8GUUOWXXVHnDyOVTm/q59GW1o3XxfHt viGA== X-Gm-Message-State: AOAM532d3VUG4GPrxj89Am/Z4ERVnQKocMxQ6tT0Pwd1FKewMnUO0laQ KIWxZcocnW/OzO1ELZo+MRjVSYGzeFA= X-Google-Smtp-Source: ABdhPJyulyKqrao2iJ1fSW7G0U8k5Py0zTJKkXaXD6b1Dm5rNw8v7p2Fr+FY0Om+ExXuWWG74i9DvA== X-Received: by 2002:a19:f001:: with SMTP id p1mr7487505lfc.447.1616363909275; Sun, 21 Mar 2021 14:58:29 -0700 (PDT) Received: from grain.localdomain ([5.18.171.94]) by smtp.gmail.com with ESMTPSA id f10sm910325lfh.61.2021.03.21.14.58.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Mar 2021 14:58:28 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id 0AC23560181; Mon, 22 Mar 2021 00:58:26 +0300 (MSK) Date: Mon, 22 Mar 2021 00:58:26 +0300 To: Vladislav Shpilevoy Message-ID: References: <9ab1c358c2fda852d7f241dc7ccd3ca4381017bd.1616200860.git.v.shpilevoy@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9ab1c358c2fda852d7f241dc7ccd3ca4381017bd.1616200860.git.v.shpilevoy@tarantool.org> User-Agent: Mutt/2.0.5 (2021-01-21) Subject: Re: [Tarantool-patches] [PATCH 14/16] sio: increase SERVICE_NAME_MAXLEN size X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Sat, Mar 20, 2021 at 01:42:36AM +0100, Vladislav Shpilevoy wrote: > > -enum { SERVICE_NAME_MAXLEN = 32 }; > +enum { > + /** > + * - Unix socket path is 108 bytes max; > + * - IP(v4, v6) max string len is 45; Actually IPv6 may include a scope as well. Currently at least libc indeed does limit it to 45 symbols plus eos mark so we're safe. Still 200 seems to be much over the top, maybe 128 instead? Also pow2 gonna be easier to manage by any memory manager. I don't insist though just a thought and this could be tuned up on top.