From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 115026EC56; Thu, 18 Mar 2021 23:45:57 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 115026EC56 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1616100357; bh=x8MdZw0GnVOnhCeWjuoNyhZUTm1ghSBIZQ0LUmx+QFw=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=PEoWW2o7rbNyzFIaHrvIFirnUXC+XAisiGn3CEJoOyVa/AWMlJ/qap/8LLVlZpCgy e3WChObUeUnPIXlTFIDJ/6rh5K3O+Rmv7o9CXhFmT2b/DR5Cc8TS8TADu6YfV02f1t Fbg+7EJDv0ma8VD2wWmCJJnfwvn0ECXfRDeig3CA= Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 8241D6EC56 for ; Thu, 18 Mar 2021 23:45:55 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8241D6EC56 Received: by mail-lj1-f178.google.com with SMTP id 184so9204877ljf.9 for ; Thu, 18 Mar 2021 13:45:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=AS/577vZEQTC9B3IvCLpGMGfrawLNEKIvyKYyMEi0eM=; b=pAJgKczmfNwqnrOXla3v+EmlktpZETEdctFEc7UOTD4Uq7uYtqvf9X7nGBe9uTbB8X Rq3STtmxI8Xj+dbTly+j4dTThnNmfdAHfK2PvGtd9tbk2q6bwkdrxUjE6XupY9Wx0Zi2 NdVZrNLs/qeidRgYBglvLup27weCPf8AmMxgmT68QRSmLSG9iwsJ8VT0Xkcc1W83JSbq Ahj/C6CawAgzeEw+bXGm4Kw++tvqkHn5pBaxeozQ5K5sZXpp/c6wDXBOj5pdoYd1OaHk MNGHrI0Zafoils5q2TnFd0ZPaAYv9M3bO9WG0T5eDO/QvE0Uj1jgzEbAAL4f235rfiZY sXtQ== X-Gm-Message-State: AOAM53235pFKqQgtEzskF17QOl4I0q/g6BwkxnqmskfFFxBeQ7gcXAjm 4cOvmV6Mjq9j/LAw/Ds9o/o= X-Google-Smtp-Source: ABdhPJzI2zu13iyGxdwLbwTr1lzOFFNy+bdPxAn6FaN9YLm19jl8Dkmqfuc+faWbMPnuMnx9ssoAag== X-Received: by 2002:a2e:5757:: with SMTP id r23mr6435926ljd.305.1616100355095; Thu, 18 Mar 2021 13:45:55 -0700 (PDT) Received: from grain.localdomain ([5.18.171.94]) by smtp.gmail.com with ESMTPSA id t200sm363700lff.280.2021.03.18.13.45.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 13:45:53 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id 3A9BA560133; Thu, 18 Mar 2021 23:45:53 +0300 (MSK) Date: Thu, 18 Mar 2021 23:45:53 +0300 To: Vladislav Shpilevoy Message-ID: References: <20210317185743.964278-1-gorcunov@gmail.com> <20210317212350.GA224985@starling> <20210318051812.GB224985@starling> <20210318075127.GA4019@starling> <2cab3281-33f8-7a59-384b-41364501e57d@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2cab3281-33f8-7a59-384b-41364501e57d@tarantool.org> User-Agent: Mutt/2.0.5 (2021-01-21) Subject: Re: [Tarantool-patches] [RFC] gc/xlog: delay xlog cleanup until relays are subscribed X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Cc: Mons Anderson , tml Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Thu, Mar 18, 2021 at 09:36:33PM +0100, Vladislav Shpilevoy wrote: > >> b) If replicas are not connected and timeout is > >> expired we kick the cleanup fiber; > > > > I mean this. > > Then it should have 'replication_' prefix, not 'wal_'. Because > it is ignored if replicas connect before the timeout expires. Replication is one of the reason while main gamer is "wal" here. In the series I sent recently I named it "wal_cleanup_delay". In future we might introduce some topology detector as you've been suggesting and better to not stick to "replication" prefix I think.