From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 9954F6EC56; Thu, 18 Mar 2021 00:53:19 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9954F6EC56 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1616017999; bh=EkIzdI5dVg+NMH1lQS3Sa3QiacbA3IOZC+6waZcC6Vs=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=g3jvS8qqlvNIvHb7pTriLk57igyM7aWQLpRSnTjHeHHwqDdBAZTavNcRATWumgtsq X1cwOftka5sB5OtwEfa7hgPuNa+v5gXVL0apus8IyW/Kc8vwz3yvAGb7seAkWmmzo9 I+EFlfyqqJBXxtkwV+uJUpEnhWnTQiT0GtgeNQ9I= Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 2626D6EC56 for ; Thu, 18 Mar 2021 00:53:18 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2626D6EC56 Received: by mail-lj1-f180.google.com with SMTP id y1so5029877ljm.10 for ; Wed, 17 Mar 2021 14:53:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=FsvRQweP8jeiysDLvHBJ815ECXNxGUci3F0wBpkDZLs=; b=T16Xw+jqiNnvocX04RR6Cw2HXwTegp586K/2F7FHElOlvsPBB87nhJ5ihKS40uQU9K K1NPOiP04tNSWQT6Uv1D6dEQj91TMXr/FB62g3w+VIgnPKEF9JN9jQ8KxjDKxc/YQ03T M3C1wtag6krcLVCbAa/9rQRS77bWu8rciYlicuNoZqidI8iO4ICD7ZA6XvXu2k4MkRoT DQmpY0taSMwq8gDf7dapYmFTSwdfTToRWjKu1bEm+8UUPtPAdN+eRPoUlNQD6hP1sTny VQ0InTXMlbJb1LxePZ7QGQw9Go6f7WN5fUNXSUpw5iNnEQlvaf+xQ8o24ey+36u2+zhQ FjeQ== X-Gm-Message-State: AOAM5322e23CaPkNcyd3e3W29dKpf1sZB57dgbRQhaUae4unDU7LLcJS jjQD5g3UZqlzA/RIApgkG+mADMGMSBk= X-Google-Smtp-Source: ABdhPJzwtu1z5kUvJh4379xOH55vBdf6qwyAR/9YnIVbAQDdA4kD2GMnXjdkDlA+WfhbFcbamwrWzg== X-Received: by 2002:a2e:a312:: with SMTP id l18mr3556791lje.106.1616017997709; Wed, 17 Mar 2021 14:53:17 -0700 (PDT) Received: from grain.localdomain ([5.18.171.94]) by smtp.gmail.com with ESMTPSA id 28sm21893ljv.125.2021.03.17.14.53.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Mar 2021 14:53:16 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id 2BE0A56013A; Thu, 18 Mar 2021 00:53:16 +0300 (MSK) Date: Thu, 18 Mar 2021 00:53:16 +0300 To: Konstantin Osipov Message-ID: References: <20210317185743.964278-1-gorcunov@gmail.com> <20210317212350.GA224985@starling> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210317212350.GA224985@starling> User-Agent: Mutt/2.0.5 (2021-01-21) Subject: Re: [Tarantool-patches] [RFC] gc/xlog: delay xlog cleanup until relays are subscribed X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Cc: Mons Anderson , tml , Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Thu, Mar 18, 2021 at 12:23:50AM +0300, Konstantin Osipov wrote: > * Cyrill Gorcunov via Tarantool-patches [21/03/17 22:01]: > > > In case if replica managed to be far behind the master node > > (so there are a number of xlog files present after the last > > master's snapshot) then once master node get restarted it > > may clean up the xlogs needed by the replica to subscribe > > in a fast way and instead the replica will have to rejoin > > reading a number of data back. > > Should be in 1.10 as well. Sure, but first I need to be sure if current rfc is acceptable in general and I didn't miss something. I suspect we might need to extend this code and better to not make some design mistakes which gonna be hard to resolve later. I've a test case for this simply didn't posted it yet.