From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id D53C26F3C8; Sat, 27 Mar 2021 00:59:14 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D53C26F3C8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1616795954; bh=CSq7UtSNmw6fP+ogMq1Kw35up3ZUtjr4eslg3DEuLHU=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=OSpZqSiL1jSrgDW8WAXg6VaibVscQ6nOSKOAm9bnKfJlu40OGbl/WYUHqpGZNBume ezJN0rNrDCYd3oPearTN0KcWqXLpUwuYy0Tsi6h8RKiUQnYZBGb/qZwvPZ6GTqroBK bapj1mEW3YqkTpMAsyKzDFYP1/fuOL4TRIYaYP+E= Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 524846F3C8 for ; Sat, 27 Mar 2021 00:59:13 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 524846F3C8 Received: by mail-lf1-f51.google.com with SMTP id b4so9790743lfi.6 for ; Fri, 26 Mar 2021 14:59:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=6QRFFLq/8ka8JpOC4zkpMiPHFWP7XNwO+RzopJA2u1M=; b=bzXCs1qHmFhPacK+pmle3tX9RCqW83OStVf8S6MEBGfA5NUqH3f3ZtLFv4EN4YvBz/ 0gDrQ15ueQ+Qk/aTlatFiauwdtVdyP81zG8CrHXM59EmYVXjQd/FtGipBY1QbGAbDVQ4 0DY9+wl6hxhV3e0RyW+J4IJZ8JLJbqvNwstoyHG3dwHIpZR03Td/noS7hLT34jF41XMk GoORej/BlIyYFHH5L767njKxkMefabPyy51hmLPd8GBlY2hSn/4PR3dl4LeeWAhrhOUD VQz1twbpPre2qEHOpg/tz58xFB3ij6k3Mjb7LjW3aVTanlGhCmJluZ/uU5irfXATKDUM LFpQ== X-Gm-Message-State: AOAM531xoov8ZYPV71gySV5x+MKu+htoU1PtU+sGLJVZjrKEO0fC1FJB /hzAiQyK4SWZ16oWS9F40afX6PEyMgHFaA== X-Google-Smtp-Source: ABdhPJyWEX7nVaLRMO5jkZpUeKyddF/OCUvZnkb8A2OvTyoTmhgEFKNCJWzTohYtsdcgumF4EvJKNg== X-Received: by 2002:a05:6512:200a:: with SMTP id a10mr8956085lfb.564.1616795952102; Fri, 26 Mar 2021 14:59:12 -0700 (PDT) Received: from grain.localdomain ([5.18.171.94]) by smtp.gmail.com with ESMTPSA id g10sm983669lfu.265.2021.03.26.14.59.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 14:59:10 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id BF0CD56014E; Sat, 27 Mar 2021 00:59:09 +0300 (MSK) Date: Sat, 27 Mar 2021 00:59:09 +0300 To: Vladislav Shpilevoy Cc: tml Message-ID: References: <20210326120605.2160131-1-gorcunov@gmail.com> <20210326120605.2160131-2-gorcunov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.0.5 (2021-01-21) Subject: Re: [Tarantool-patches] [PATCH v5 1/3] gc/xlog: delay xlog cleanup until relays are subscribed X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Fri, Mar 26, 2021 at 08:45:29PM +0100, Vladislav Shpilevoy wrote: > > +++ b/test/replication/replica_rejoin.lua > > @@ -0,0 +1,22 @@ > > +#!/usr/bin/env tarantool > > + > > +local repl_include_self = arg[1] and arg[1] == 'true' or false > > 1. Why do you need that parameter? It is never used in the patch. It is used on replica > > > +local repl_list > > + > > +if repl_include_self then > > + repl_list = {os.getenv("MASTER"), os.getenv("LISTEN")} > > +else > > + repl_list = os.getenv("MASTER") > > +end > > + > > +-- Start the console first to allow test-run to attach even before > > +-- box.cfg is finished. > > +require('console').listen(os.getenv('ADMIN')) > > + > > +box.cfg({ > > + listen = os.getenv("LISTEN"), > > + replication = repl_list, ^^^ here And we run replica with test_run:cmd("restart server replica with args='true'") ... Since I use a separate replica_join.lua we could drop this `if repl_include_self` sentense since we never call replica with args='false'. I'll re-check.