From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 57FD86F3C7; Fri, 26 Mar 2021 23:57:51 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 57FD86F3C7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1616792271; bh=yH6tCrk4efbmZiffindFxGvaEcLjTGvevwxaezjvqPw=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=dF85HBADB9haOaPZyn3W9pdJHWFcPMTfmoWAcy70awle60yQjZnFHLDl4++3zEOQP TnP5heepIGHq+XUmAugkw00QOimO4X3qoWfjh1wCh7H8MZ2BjTlLtjSaMZKA2GQF1P oJ73AZuamPss83mft6YxpErL2S6TthLnBVhhMNYU= Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 9E8FC6F3C7 for ; Fri, 26 Mar 2021 23:57:49 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9E8FC6F3C7 Received: by mail-lf1-f49.google.com with SMTP id o126so9661974lfa.0 for ; Fri, 26 Mar 2021 13:57:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=yUIYpBwLR/sBNyaOmqV+tatje1UgkU5JM5CcbSztQbg=; b=c5RHtodHZ3YFC/PlxAMn4Wubo7QVfQaI8bkJ9LebP1OIkWlH/0/pQvS3oK1tFGmCQS z8gyS/qERlRBST82DJQvlzdskr80SD4Lu4mNwBP2cd57Qpb2balSBaa3Zv54P8+k6nn1 9Vu+27prV6uW5cwf7TtU+ZMN6e9bd3mn11389Lw7QX4hv7uzbTsPNEBz381HPZ0tVuA8 rDDsB1IovpmN5tJw6K/pt7lYfzFlgwGSc9tVYeqy/jWCHSjyHIUyVj7Ig6mwPXPjqnHb 3AJz+RyPw6LxTXbRu1fYSuPRR8SdbIQwKbagC1Q/qY3GI6XW1cXhuvGJF9dghEd2z2IY /phA== X-Gm-Message-State: AOAM530FTO2mLzclz6hJ2M1zKL+Qsc/Ag6tHJI8PQTqI5ENKzxdlntjv 2zh5Vgj3JPJ5e0/Tse5kfrx0KHxZsuKtJA== X-Google-Smtp-Source: ABdhPJxFnAzel/Y34vNNHI2dMS0a5ATyFCRWSS98jaTgTAPXTCGCBGB48Tza0f9HSAycNPzH4mRmfw== X-Received: by 2002:a19:385e:: with SMTP id d30mr9056175lfj.497.1616792268509; Fri, 26 Mar 2021 13:57:48 -0700 (PDT) Received: from grain.localdomain ([5.18.171.94]) by smtp.gmail.com with ESMTPSA id d8sm1298166ljc.129.2021.03.26.13.57.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 13:57:47 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id 8B0E656014B; Fri, 26 Mar 2021 23:57:46 +0300 (MSK) Date: Fri, 26 Mar 2021 23:57:46 +0300 To: Vladislav Shpilevoy Cc: tml Message-ID: References: <20210326120605.2160131-1-gorcunov@gmail.com> <20210326120605.2160131-2-gorcunov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/2.0.5 (2021-01-21) Subject: Re: [Tarantool-patches] [PATCH v5 1/3] gc/xlog: delay xlog cleanup until relays are subscribed X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Fri, Mar 26, 2021 at 08:45:29PM +0100, Vladislav Shpilevoy wrote: > Hi! Danke schön für der Patch! > > See 3 comments below. > > > > + replication_timeout = 0.1, > > + wal_cleanup_delay = 0, > > 3. I would better propose you to patch replica.lua so as we could > pass wal_cleanup_delay parameter to it somehow. But I don't mind > if you would keep your way + remove the dead code above. > ありがとう！ Gimme some time, I'll try to patch replica.lua, if I won't manage I'll drop these redundant lines. Cyrill