From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B2B626F3C7; Fri, 26 Mar 2021 19:46:48 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B2B626F3C7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1616777208; bh=aQJhR1GEVt/v72MghMyf1SM5E3pkWXvl3rRElxnrNU8=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=YCnM/3X6f4cdlUlP8CCnS6dD56dxnLSrpiPeEho2f8VplrNiKwgoo+tPHs0i2HJqf GzUmqrRQVGd7LnF/L80aFRgix9jK65Cgt5a5848SgHsFUBp3zo48Loine4v8uInmoe m9YlQx0Ogxmkx6qowiSfu8W9lsw6VD1xtCyxVxns= Received: from smtp53.i.mail.ru (smtp53.i.mail.ru [94.100.177.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 4D9056F3C7 for ; Fri, 26 Mar 2021 19:46:48 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4D9056F3C7 Received: by smtp53.i.mail.ru with esmtpa (envelope-from ) id 1lPpbj-0000UP-B3; Fri, 26 Mar 2021 19:46:47 +0300 Date: Fri, 26 Mar 2021 19:45:54 +0300 To: Sergey Ostanevich Message-ID: References: <0e928a814f30027c58bcd7b6e587f811ed5a6dfc.1616743343.git.skaplun@tarantool.org> <2CF6AD3A-89CD-4599-A108-7D801D4F4B2F@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2CF6AD3A-89CD-4599-A108-7D801D4F4B2F@tarantool.org> X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E329498ADEA61F680B110809A4DE3E6FC56EA182A05F53808504054B3AF4FFC04B8B5D97DCD0D95AA4A6E3A7DA895E1C41AEE21CEA2577765C485 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE783C1FBFE215D363AEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637DC5B68A43B0CFEA28638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C5DD32608FC869F5D4AD71C95F79FE85A221B4B6C080D8A46A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE71AE4D56B06699BBC9FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C327ED053E960B195E117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947C0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E735262FEC7FBD7D1F5BB5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A589C1005888CE55FBA4F630C0F444C9E12F668AF530F42B1DD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D348B532EA2091F4FF666AC63858B0B7CF6EA731476313FC653FCA7FA6345CE662AA8D3BF1F4F4022AE1D7E09C32AA3244C067B143D3D77962F0A7E5EE758B01A326C24832127668422FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojapPp7P/VpAjOB5b+L4LiHg== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB42449EDE52986B3AC736E7304CDEDBD5567C75BCA22D204DAF2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A89437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 30/30] test: disable too depth recursive PUC Lua test X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, thanks for the review! On 26.03.21, Sergey Ostanevich wrote: > Did you look into the fiber_new_ex() interface? > I bet it’s doable to create a fiber with big enough stack. Yes, there is necessary `stack_size` field in given `struct fiber_attr`. But I don't see a Lua interface for stack manipulation. May be it is necessary to create fiber via preparing chunk in and use it. Looks like out of scope of this ticket. Is it necessary to create a follow-up ticket? > > Again, not about follow-ups: LGTM. > Sergos > > > > On 26 Mar 2021, at 10:43, Sergey Kaplun wrote: > > > > The first Tarantool's fiber has only 512Kb of stack. > > It is not enough for depth recursive call in the test for > > `string.gsub()`. > > > > This patch disables test leads to Tarantool crash. > > > > Relates to tarantool/tarantool#5782 > > Resolves tarantool/tarantool#5845 > > Part of tarantool/tarantool#4473 > > --- > > test/PUC-Lua-5.1-tests/pm.lua | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/test/PUC-Lua-5.1-tests/pm.lua b/test/PUC-Lua-5.1-tests/pm.lua > > index b159b6b..c6e42df 100644 > > --- a/test/PUC-Lua-5.1-tests/pm.lua > > +++ b/test/PUC-Lua-5.1-tests/pm.lua > > @@ -207,7 +207,11 @@ function rev (s) > > end > > > > local x = string.rep('012345', 10) > > -assert(rev(rev(x)) == x) > > +-- The first Tarantool's fiber has only 512Kb of stack. > > +-- It is not enough for this recursive call. > > +-- See also https://github.com/tarantool/tarantool/issues/5782. > > +-- FIXME: The test is disabled for Tarantool binary. > > +-- assert(rev(rev(x)) == x) > > > > > > -- gsub with tables > > -- > > 2.31.0 > > > -- Best regards, Sergey Kaplun