From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id D73156F3C7; Fri, 26 Mar 2021 19:02:28 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D73156F3C7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1616774548; bh=BcyGJVRtQO0zM2kIZpcg7wrSY1fwNcVZV4kIT63zlEQ=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=MkQYoXHwEqkNqDGEPRJ2BCFU6btBgSNBcbDCZ+8JfBzwH96mUjgJ1gCFAwH8r6QGi Jp52gRXHQmucHOYbZQ4jpxzPD581Mi2V5N2iDuM3+/u4PnO4J5Z9f0jyAknNh7Ojj2 QZ9F5U03QNVp7KALEmplucC+w7XPMUQhNWSEaNKE= Received: from smtp39.i.mail.ru (smtp39.i.mail.ru [94.100.177.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D61BA6F3C7 for ; Fri, 26 Mar 2021 19:02:27 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D61BA6F3C7 Received: by smtp39.i.mail.ru with esmtpa (envelope-from ) id 1lPouo-0004Ou-Np; Fri, 26 Mar 2021 19:02:27 +0300 Date: Fri, 26 Mar 2021 19:01:33 +0300 To: Sergey Ostanevich Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E3294294B90A37D0C277F3D6300B1E29D1C98182A05F53808504030CEAC42BFC414AF36D75D75AA09482909908CE7CBFE211177E0ED54E1847B6B X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE716FAD50E497B9C14EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063702DFA59B3C994360EA1F7E6F0F101C67CDEEF6D7F21E0D1D174C73DBBBFC7664183FC4D1B98D6C03E823FDEDC216B0D75B9ED709B22E70A9389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C07E7E81EEA8A9722B8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B64854413538E1713FCC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB86D1867E19FE14079C09775C1D3CA48CFC5EA940A35A165FF2DBA43225CD8A89F890A246B268E114E57739F23D657EF2BB5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A59D20AA7D7CADAF505E10DA81C0A7DB7A9AB78CC1D26D43C2D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34AC6E62257D6CD1C99CE6BF88A07B052FEF88D1246C3D8E85C08C22A7CB1A9AFB2E90786CE3F41C491D7E09C32AA3244C953006CCECBCA0A7A8B215B1B133B3A68894E9C85370243EFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojapPp7P/VpAi7TchkC497Xw== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB4D405387EEE20159C096E1A4B978F6D433D34EEA4F3A34A11F2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A89437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 22/30] test: disable PUC Lua test for var names in error X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thanks for the review! On 26.03.21, Sergey Ostanevich wrote: > Nit in message, LGTM. > Sergos > > > On 26 Mar 2021, at 10:43, Sergey Kaplun wrote: > > > > LuaJIT includes variable name to the error report, when try to > > call non-function object without __call methamethod. > > Also, LuaJIT includes variable name to the error report, when try to > > perform unacceptable arifmetic operation with the variable. > arithmetic Thanks! The new commit message is the following: =================================================================== test: disable PUC Lua test for var names in error LuaJIT includes a variable name to the error report, when try to call non-function object without __call methamethod. Also, LuaJIT includes a variable name to the error report, when try to perform unacceptable arithmetic operation with the variable. Lua 5.1 doesn't report variable name in these errors. The test checked that variable name aren't reported are disabled by this patch. Part of tarantool/tarantool#5845 Part of tarantool/tarantool#4473 =================================================================== > > Lua 5.1 doesn't report variable name in these errors. > > > > Test ckecked that variable name aren't reported are disabled by > > this patch. > > > > Part of tarantool/tarantool#5845 > > Part of tarantool/tarantool#4473 > > --- > > test/PUC-Lua-5.1-tests/errors.lua | 9 +++++++-- > > 1 file changed, 7 insertions(+), 2 deletions(-) > > > > diff --git a/test/PUC-Lua-5.1-tests/errors.lua b/test/PUC-Lua-5.1-tests/errors.lua > > index e881211..cf24e40 100644 > > --- a/test/PUC-Lua-5.1-tests/errors.lua > > +++ b/test/PUC-Lua-5.1-tests/errors.lua > > @@ -72,8 +72,13 @@ checkmessage("b=1; local aaa='a'; x=aaa+b", "local 'aaa'") > > checkmessage("aaa={}; x=3/aaa", "global 'aaa'") > > checkmessage("aaa='2'; b=nil;x=aaa*b", "global 'b'") > > checkmessage("aaa={}; x=-aaa", "global 'aaa'") > > -assert(not string.find(doit"aaa={}; x=(aaa or aaa)+(aaa and aaa)", "'aaa'")) > > -assert(not string.find(doit"aaa={}; (aaa or aaa)()", "'aaa'")) > > +-- LuaJIT: LuaJIT includes variable name to the error report. > > +-- It looks like: > > +-- "attempt to perform arithmetic on global 'aaa' (a table value)" > > +-- Lua 5.1 doesn't report variable name here. > > +-- Tests are disabled for LuaJIT. > > +-- assert(not string.find(doit"aaa={}; x=(aaa or aaa)+(aaa and aaa)", "'aaa'")) > > +-- assert(not string.find(doit"aaa={}; (aaa or aaa)()", "'aaa'")) > > > > checkmessage([[aaa=9 > > repeat until 3==3 > > -- > > 2.31.0 > > > -- Best regards, Sergey Kaplun