From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 544496F3C7; Fri, 26 Mar 2021 17:34:39 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 544496F3C7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1616769279; bh=X23SFq50Imonp/u+iPzHib4Ipb5xM/dV2fl82IueEp8=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=nbT3UQDaOxTAYJZeFFzemCc5DqWkCIASwPKUeAlYb7Ez5t49JXvPUnk+CGrAS3mPu nVlW8eRfUosFfq9W5pOcQGjucqUPiEy0M6xULuqdEtLs/EWH8QaSz7YYIGcngrzbgc 8G5gKlTfb3GTghLcNZyBEtP0fW7ayHriAASj8D/k= Received: from smtp3.mail.ru (smtp3.mail.ru [94.100.179.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id BB0C56F3C7 for ; Fri, 26 Mar 2021 17:34:38 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BB0C56F3C7 Received: by smtp3.mail.ru with esmtpa (envelope-from ) id 1lPnXp-0005mr-S9; Fri, 26 Mar 2021 17:34:38 +0300 Date: Fri, 26 Mar 2021 17:33:45 +0300 To: Sergey Ostanevich Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E3294DD38BE31D7797EF84C856624A09E4809182A05F53808504005819EB9A65A66331DF6CCD7F8544511B4F5351F77D49AE5501D7EB287E8AA45 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7DECE8D0A5E25C0FCEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637E893C22CB255350D8638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C5DD32608FC869F5DF3DE4B8DA97E72B8ABAF286E839C925FA471835C12D1D9774AD6D5ED66289B5278DA827A17800CE70F3DDF2BBF19B93A9FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3E97D2AE7161E217F117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947C0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E73528A6D463EDFD0DBBC4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A5C93365E831B9AD7F3A72B0DC77AE9DB5A459F2094A649C94D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34EC58E35A639A24719F8D886D40A8E25D191569D4EC184AAEAE02F3C0F1655017F663F691AE2F17DC1D7E09C32AA3244C8CC59D2C2E0D8B687D7591676777A8805595C85A795C7BAEFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojapPp7P/VpAhJ0xYQg9UgdQ== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB48C3AA1BD39EE925A30914156BBF72D1F405AA7DBB3C39D03F2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A89437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 09/30] test: disable Lua suite tests for line hook X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thanks for the review! On 26.03.21, Sergey Ostanevich wrote: > Follow-up ticket ? It is mentioned by this line (IIUYC): | Relates to tarantool/tarantool#5693 > > LGTM. > Sergos > > > On 26 Mar 2021, at 10:42, Sergey Kaplun wrote: > > > > FIXME: LuaJIT interprets a return from a new function loaded by > > `loadstring()` with a change line number for bytecode position > > unlike Lua does. This looks like "implementation-defined behaviour" > > mentioned in https://luajit.org/status.html. > > > > All tests checked the debug hook for a new line of code are affected > > and disabled by this patch. > > > > Relates to tarantool/tarantool#5693 > > Part of tarantool/tarantool#5845 > > Part of tarantool/tarantool#4473 > > --- > > test/PUC-Lua-5.1-tests/db.lua | 19 ++++++++++++++++++- > > 1 file changed, 18 insertions(+), 1 deletion(-) > > > > diff --git a/test/PUC-Lua-5.1-tests/db.lua b/test/PUC-Lua-5.1-tests/db.lua > > index 9d2c86f..a8c7196 100644 > > --- a/test/PUC-Lua-5.1-tests/db.lua > > +++ b/test/PUC-Lua-5.1-tests/db.lua > > @@ -95,6 +95,23 @@ repeat > > assert(g(f) == 'a') > > until 1 > > > > +-- FIXME: LuaJIT interprets a return from calling result of > > +-- `loadstring()` with a new line number unlike Lua does. > > +-- Here is an example (it is joined in one line intend): > > +--[[ > > +debug.sethook(function(_, l) print("LINE: "..l) end, "l") loadstring("\n\ns=nil")() debug.sethook() > > +--]] > > +-- This chunk prints for LuaJIT: > > +--[[ > > +LINE: 3 > > +LINE: 1 > > +--]] > > +-- But for Lua 5.1 it is only "LINE: 3" in the output. > > +-- See also https://github.com/tarantool/tarantool/issues/5693. > > +-- Considering implementation-defined behaviour diference > > +-- (see also https://luajit.org/status.html) test is disabled for > > +-- LuaJIT. > > +--[=[ > > test([[if > > math.sin(1) > > then > > @@ -149,7 +166,7 @@ end > > ]], {1,2,1,2,1,3}) > > > > test([[for i=1,4 do a=1 end]], {1,1,1,1,1}) > > - > > +--]=] > > > > > > print'+' > > -- > > 2.31.0 > > > -- Best regards, Sergey Kaplun