From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 3C93E6F3C7; Fri, 26 Mar 2021 17:32:44 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3C93E6F3C7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1616769164; bh=4PmiPf0PAlJUkv5kbd2BLhDFnQwDQMBB7SfI+6wvEIM=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=F26Vhvo8m/3I+jsPLL0mL1udbPxAHELBEz5H60NizFz0tZz+WvGt0FowWIRTum+6G OmmfpK7r2T+SRcflUULvQYTvrRXi9hQMiuZGwq/J1GGCWiMbXpwzVHd7BaEGeobKv7 ZLsE4jy7/bEdEsKMA23dBQhlNU8hd7W2Xv9K6XSI= Received: from smtp32.i.mail.ru (smtp32.i.mail.ru [94.100.177.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 628716F3C7 for ; Fri, 26 Mar 2021 17:32:43 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 628716F3C7 Received: by smtp32.i.mail.ru with esmtpa (envelope-from ) id 1lPnVx-0004AO-Ua; Fri, 26 Mar 2021 17:32:42 +0300 Date: Fri, 26 Mar 2021 17:31:49 +0300 To: Sergey Ostanevich Message-ID: References: <05d8289981e0933402c01659b6785a309d289036.1616743343.git.skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947A0146560F8BA709498CFB6209D8582A182A05F538085040EA2489D0F7B95DC7CE0860D0400418B7C89818E2BBC3CBFC385392732C5608D4 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7BC08626EA5717D14EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637F97367C191A19EB28638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C5DD32608FC869F5D5F4AA14B0A5CA688404A651A40CDFCA8A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE71AE4D56B06699BBC9FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C34964A708C60C975A117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947C0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E735F1C9CF18C8EB2269C4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A565514E4AABD582A91209F5240464BE75E1BDE226B88BA15CD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D344E332383F80D58BB1975A08770F5E99E320AE0E144E468B994DBDDBA34526BA23B26D7C09C5C27C21D7E09C32AA3244CB6AB754557CC6AF2D2B50C2CC4A96692E3D93501275E802FFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojapPp7P/VpAjk//pyi1W8Bg== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB4DAAF7781F0F809A9F30DEDF625A146466D2E46E8818D565AF2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A89437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 06/30] test: disable PUC Lua tests confused by -v output X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thanks for the review! On 26.03.21, Sergey Ostanevich wrote: > Any follow-up ticket for this? Mention it in the commit message, and it's It is mentioned via the folowing line: | Relates to tarantool/tarantool#5687 > > LGTM. > > Sergos > > > > On 26 Mar 2021, at 10:42, Sergey Kaplun wrote: > > > > Version and status are printed in stdout instead stderr since > > LuaJIT-2.0.0-beta11 (as it is not an error message). > > See commit 0bd1a66f2f055211ef55834ccebca3b82d03c735 > > (Print version and JIT status to stdout, not stderr.). > > This behavior is the same as in Lua 5.2. > > > > This patch disables tests confused by unexpected -v output to stdout. > > > > Relates to tarantool/tarantool#5687 > > Part of tarantool/tarantool#5845 > > Part of tarantool/tarantool#4473 > > --- > > test/PUC-Lua-5.1-tests/main.lua | 28 ++++++++++++++++++++-------- > > 1 file changed, 20 insertions(+), 8 deletions(-) > > > > diff --git a/test/PUC-Lua-5.1-tests/main.lua b/test/PUC-Lua-5.1-tests/main.lua > > index c11a576..56f56a0 100644 > > --- a/test/PUC-Lua-5.1-tests/main.lua > > +++ b/test/PUC-Lua-5.1-tests/main.lua > > @@ -103,26 +103,37 @@ prepfile[[ > > RUN("lua - < %s > %s", prog, out) > > checkout("1\tnil\n") > > > > +-- Version and status are printed in stdout instead stderr since > > +-- LuaJIT-2.0.0-beta11 (as it is not an error message). > > +-- See commit 0bd1a66f2f055211ef55834ccebca3b82d03c735 > > +-- (Print version and JIT status to stdout, not stderr.). > > +-- This behavior is the same as in Lua 5.2. > > +-- In Lua 5.2 this feature was introduced via commit > > +-- 9e7de9473c65baee1f567852a778f2d33a47ea83. > > +-- See also https://github.com/tarantool/tarantool/issues/5687. > > prepfile[[ > > = (6*2-6) -- === > > a > > = 10 > > print(a) > > = a]] > > -RUN([[lua -e"_PROMPT='' _PROMPT2=''" -i < %s > %s]], prog, out) > > -checkout("6\n10\n10\n\n") > > +-- FIXME: Behavior is different for LuaJIT. See the comment above. > > +-- RUN([[lua -e"_PROMPT='' _PROMPT2=''" -i < %s > %s]], prog, out) > > +-- checkout("6\n10\n10\n\n") > > > > prepfile("a = [[b\nc\nd\ne]]\n=a") > > print(prog) > > -RUN([[lua -e"_PROMPT='' _PROMPT2=''" -i < %s > %s]], prog, out) > > -checkout("b\nc\nd\ne\n\n") > > +-- FIXME: Behavior is different for LuaJIT. See the comment above. > > +-- RUN([[lua -e"_PROMPT='' _PROMPT2=''" -i < %s > %s]], prog, out) > > +-- checkout("b\nc\nd\ne\n\n") > > > > prompt = "alo" > > prepfile[[ -- > > a = 2 > > ]] > > -RUN([[lua "-e_PROMPT='%s'" -i < %s > %s]], prompt, prog, out) > > -checkout(string.rep(prompt, 3).."\n") > > +-- FIXME: Behavior is different for LuaJIT. See the comment above. > > +-- RUN([[lua "-e_PROMPT='%s'" -i < %s > %s]], prompt, prog, out) > > +-- checkout(string.rep(prompt, 3).."\n") > > > > s = [=[ -- > > function f ( x ) > > @@ -140,8 +151,9 @@ assert( a == b ) > > =f( 11 ) ]=] > > s = string.gsub(s, ' ', '\n\n') > > prepfile(s) > > -RUN([[lua -e"_PROMPT='' _PROMPT2=''" -i < %s > %s]], prog, out) > > -checkout("11\n1\t2\n\n") > > +-- FIXME: Behavior is different for LuaJIT. See the comment above. > > +-- RUN([[lua -e"_PROMPT='' _PROMPT2=''" -i < %s > %s]], prog, out) > > +-- checkout("11\n1\t2\n\n") > > > > prepfile[[#comment in 1st line without \n at the end]] > > RUN("lua %s", prog) > > -- > > 2.31.0 > > > -- Best regards, Sergey Kaplun