From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 3A26D6F3C7; Fri, 26 Mar 2021 10:04:05 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3A26D6F3C7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1616742245; bh=yf6fXSVnhPlK6YYVPk8AeERURNy8Cu7CNuh35s7oHPg=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=x6SiAyEM4zNudb6ybDQfOsVuCudMau1WMBiX8Mkfapm4xTTy6zRmc2V5BBKqtIQUe J2eqDoUzcx+p20e3ufpjoR/81VOzVBTNzPMcv2qe08q7ItvVPg12a6cyAy/jLjsJBc M7XMHC62FPVfo6EQzVo2+y9MtBPxjPlmzp9LSVkc= Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 572236F3C7 for ; Fri, 26 Mar 2021 10:04:04 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 572236F3C7 Received: by mail-lf1-f53.google.com with SMTP id w37so6114428lfu.13 for ; Fri, 26 Mar 2021 00:04:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=lXoTXpHLG02wrmgyl95aMSk7gv9NV9yQ3ogN8WnciXY=; b=oiS7YOmkiErAN/c0L1B+83+8J/xHQVtwwfRx6xsH6tM1p4NRQaaRpCePoCTgwJs/XF D/0j5Ruz5UYSL3+Td9rKixRKBY0O/c/FnnGTYxjA11K2JIgir5BYJLoy+nw/E6pHC7SN l05JI8pUmimdvV+ysKGB3CgzPnbcU4Xo9Aq24YIrUDg/cW/+CrLox7k36YWoM1tLuO2N oQobLM/cCa40MsBKYWx+ZexFbnHuurmBI+gOkH4t51eDUO/DKrfOWlkKbNaLX8js2V/F NUBN4OlkWyX1d25aSTQ76Ll6Cj1JyNp7afEXOFq7AvkaD5uaAV/roIxqOgNfsD4jdrox haxQ== X-Gm-Message-State: AOAM532Rv6oarmwhcj0Ix3zH6JUdiy8kMHYrMMyqHKSRfg49vNzvsaYQ nPxAUwsEi8zxmcu2cxmROpaS3Wcrv3funw== X-Google-Smtp-Source: ABdhPJw4gw624veTp5+Qoue3BDnF90ZxGdbqi4Y/C6gBujzLRbfrXK9ci4i7/LpMJ/83GWhE6U3jtg== X-Received: by 2002:a05:6512:2117:: with SMTP id q23mr7216962lfr.423.1616742243242; Fri, 26 Mar 2021 00:04:03 -0700 (PDT) Received: from grain.localdomain ([5.18.171.94]) by smtp.gmail.com with ESMTPSA id e9sm1059105ljj.52.2021.03.26.00.04.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 00:04:01 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id 2B899560175; Fri, 26 Mar 2021 10:04:01 +0300 (MSK) Date: Fri, 26 Mar 2021 10:04:01 +0300 To: Vladislav Shpilevoy Message-ID: References: <20210324163759.1900553-1-gorcunov@gmail.com> <20210324163759.1900553-2-gorcunov@gmail.com> <8faa2e1e-c198-832d-d527-1acf2280720d@tarantool.org> <19605c5e-e96c-8580-6309-3b0e58df8c01@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.0.5 (2021-01-21) Subject: Re: [Tarantool-patches] [PATCH v4 1/3] gc/xlog: delay xlog cleanup until relays are subscribed X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Cc: tml Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Fri, Mar 26, 2021 at 12:50:40AM +0100, Vladislav Shpilevoy wrote: > > > > | tarantool> box.cfg{wal_cleanup_delay = math.huge} > > | --- > > | - error: 'Incorrect value for option ''wal_cleanup_delay'': value must be finite and > > | >= 0' > > | ... > > > > You don't need to change it to finite if it works fine being infinite. > I only wanted to have a test that it does not crash somewhere on that. > > If it would crash, it would mean we would need to fix the other timeouts > too. Otherwise your timeout still is inconsistent with them if you ban > the literal infinity. I personally think this is wrong to allow enter arbitrary values here but won't insist, I'll drop this test.