From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 85B966F3C5; Fri, 12 Mar 2021 20:45:40 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 85B966F3C5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1615571140; bh=vhN1uFTXsU8XH4lbd5RZG5Xx8ve84u/hX9kirxNOc6w=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=uFZc+iAR2ZYczWDTRD0N323+Gx/z1vyWPFImAXneq6T00WmfYY93jDSsg3YyhBN+G zx2Kf7aK6LKJMuWoPUATKaV2ZT7KiX9K2drt8bU80BSnN1aVBGE3c/JDwn6q0efagk Jl+rwT76UIFDfpj87pcJMNfedCAHsG9A9tyB7SUA= Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id CADFB6F3C5 for ; Fri, 12 Mar 2021 20:45:39 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org CADFB6F3C5 Received: by mail-lj1-f175.google.com with SMTP id 9so7815087ljd.7 for ; Fri, 12 Mar 2021 09:45:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=dtLO0HF4hA5BJwmqH/vqD/Usl4855t3phcnhdwDDwck=; b=L4jMbRYct+Di1VyX3fqS9jab3IipoCT9VohhB0OhxeusoYoAlfDFmkRQT+SBvDGXgN A3SgrBvzxASwT+JpMg/b1M9czbeAQzHQREt7oQQT7Vo8egthUW+YuTHLPp00jznaZ2za ADMWZgaKKuqIhl6hibO30imqKCVjozXUe4DHMfoWQgD2Ebe/1cLbPG035Flwc9YzEY8j w0fLliyiFPFNxsOwgtF3XzlBB+N62KMpxDzGpTwz8EiQdzCOhBTz7QWJKN2abh/7OK15 YTVCFC18BzAbbTDknnv0RXma/WTjcsdDGlxcTPPDrJM5llGP8/wCUa7Y7mRY/92fDJPC EOtw== X-Gm-Message-State: AOAM532sMP0ty6dbsgcoWuXsvHkgqBt8iUOr2Acc5z3yrBB+e1fZg5O5 b82eA/N05VvBAQbgrQpKghL3h3bnrFIDDQ== X-Google-Smtp-Source: ABdhPJx0lGa3glgOH7HuVnMM6LaBq3BMWx1AEsgMuzlqGE+2i7ue0ZcjNE+3mo8eeu3mCLj7FSGjPA== X-Received: by 2002:a05:651c:2125:: with SMTP id a37mr3131000ljq.19.1615571138653; Fri, 12 Mar 2021 09:45:38 -0800 (PST) Received: from grain.localdomain ([5.18.171.94]) by smtp.gmail.com with ESMTPSA id a1sm1809384lfs.197.2021.03.12.09.45.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Mar 2021 09:45:37 -0800 (PST) Received: by grain.localdomain (Postfix, from userid 1000) id 6C9D05600A2; Fri, 12 Mar 2021 20:45:36 +0300 (MSK) Date: Fri, 12 Mar 2021 20:45:36 +0300 To: Serge Petrenko Message-ID: References: <20210310204710.186461-1-gorcunov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/2.0.5 (2021-01-21) Subject: Re: [Tarantool-patches] [PATCH 0/2] A few fixes for gc and xlog X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Cc: Vladislav Shpilevoy , tml Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Fri, Mar 12, 2021 at 08:11:25PM +0300, Serge Petrenko wrote: > > 10.03.2021 23:47, Cyrill Gorcunov пишет: > > While work on https://github.com/tarantool/tarantool/issues/5806 > > is still in progress I would like to share a few patches which > > I think are useful. Please take a look. > > > > branch gorcunov/gh-5806-xlog-gc > > > > Cyrill Gorcunov (2): > > gc: use wide integer for schedule counting > > xlog: do not sort sole entry > > > > src/box/gc.c | 6 +++--- > > src/box/gc.h | 2 +- > > src/box/xlog.c | 2 +- > > 3 files changed, 5 insertions(+), 5 deletions(-) > > > > > > base-commit: 3a7c21023367424baa9bf2d4d823102cb2b3c751 > Thanks for the patchset! > > LGTM, but I doubt Vlad will like this =) Thanks! Both fixes are trivial but definitely needed ones.