From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 365147030C; Fri, 5 Mar 2021 11:26:18 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 365147030C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1614932778; bh=IDg2uKNVbXBb7ZECO0572wAuv/enGE09qyiNSlm+ZFM=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=g5z+7neK5Q3Mir5yw2hB/w2maDLvIPCYl/assmkYwoJkTZ24YRn1lrzf/LZPv4s8e wE4jzxsyQ2jERlumxCR+xRdOWsguW06JY5G3ppjv0wVf58+jcOGcgfQHi5JPIBhHqb Q0ZKrGjYWfpCp7Lb5cN81TvdUrVQkv+5RIjtYejo= Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 5AA697030C for ; Fri, 5 Mar 2021 11:26:16 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5AA697030C Received: by mail-lj1-f171.google.com with SMTP id 2so1696494ljr.5 for ; Fri, 05 Mar 2021 00:26:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=JVGAmUUo7mzYiQoXHywBwfeDhjH/zGQHqg4L57jfE4E=; b=bjmKDvuMCKEDH78dClzu4/sDoOQ8Tgw1F5zL/wk1lRZePXtXW7L9yki006NkW6sqpP s+yqOebbDHFj1qMbfDiwo3temnoHHUKc9ENpeHUZryuFMQZy317hb/lybGCXxeOcYm9q XAZZxuepTq6mGPcSvIufNk88ZxA9h00UhFOjHBbnjPVQ/wCVIJPXOuAZkwa7fsHOLDVb whYV/0Y3yxm6rE699IsIzZRk70ibd3YVHK1JSib1DMiRMZNIP9/ZSKlNJ0tY4W2+FMao tbTo4b6UXO9NlhaAis/JCkoZKxn66nR3EoEm/CFDSgYzKPHPKmaLkH2XiepoxdbfY8wo QlfQ== X-Gm-Message-State: AOAM5319RPduDC0Y3xQeWhKyXDicwBoHMTdvt6s8GvTofogzwXzsVNUp XfePK4eKuscF0na/Nj4sVXoBotpxLdo= X-Google-Smtp-Source: ABdhPJyG2F0JCjByyLPrUKtZ0P/ESZzkduHWOaWZPOm3VvyLs3kzywAlyjjThxPh+aBcaKiaGv5Zeg== X-Received: by 2002:a2e:381a:: with SMTP id f26mr1510575lja.205.1614932775253; Fri, 05 Mar 2021 00:26:15 -0800 (PST) Received: from grain.localdomain ([5.18.171.94]) by smtp.gmail.com with ESMTPSA id z1sm216089ljh.29.2021.03.05.00.26.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Mar 2021 00:26:13 -0800 (PST) Received: by grain.localdomain (Postfix, from userid 1000) id 4E113560160; Fri, 5 Mar 2021 11:26:13 +0300 (MSK) Date: Fri, 5 Mar 2021 11:26:13 +0300 To: Aleksandr Lyapunov Message-ID: References: <20210304142515.65862-1-gorcunov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.0.5 (2021-01-21) Subject: Re: [Tarantool-patches] [PATCH] xlog: fix arguments processing in commit 8e429f4b7 X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Cc: tml , Alexander Turenko Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Fri, Mar 05, 2021 at 11:16:01AM +0300, Aleksandr Lyapunov wrote: > Hi! thanks for the patch! > > Actually we found the error an fixed it in #5823. > You can see identical commit 733081f7042974f8fee9431e46cd45d2f1601438 . > But again thanks for your cooperation! Aha! I see, thanks! You know the patch you merged in actually still buggy --- + } else { + int rc = unlink(filename); + xdir_say_gc(rc, errno, filename); + } The compiler has all rights to fetch @errno _before_ evaluating_ unlink, there is no dependency. We might need a barrier. My patch did + int rc = unlink(filename); + int _errno = rc != 0 ? errno : 0; + xdir_say_gc(rc, _errno, filename); here is _errno depends on unlink with a purpose.