From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 76EBB7030F; Thu, 25 Feb 2021 10:52:23 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 76EBB7030F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1614239543; bh=n30AgkxZgOA8gSHOGcUCGgTPuhjAB7BUwMKMW9PwagM=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=YuwWFf1qKGArwmwGSeuUa3blUI9Zcf0Adh6sbi+8zHPhWNNd8HY2f5e7iPTRSjbwn +P98PExW9L7QCL5Zl++TgNCMngNCHrvgfMjil1OQ1KopnTXEJfd++dsNlkkjn6wMlB viIjxH5NKe6o/u0OOEkkD4NT0BfJcRyiMANXKFMk= Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 5CF677030F for ; Thu, 25 Feb 2021 10:52:22 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5CF677030F Received: by mail-lf1-f48.google.com with SMTP id f1so7194111lfu.3 for ; Wed, 24 Feb 2021 23:52:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=cbh40GamllgBrrmK4NwTV4XoS63NRd9nWxvdtff1N2I=; b=HEuAr2LfW4UY/oejD49dWfHHJmFQoiaWTsb88wqxCtNIwzAFNXcM16W2chZJFZvOUB NfslBkdeRITyCCQWR78EmZxWCrKbsix2I46yonz3OFEq/D17/BtM8YyXhV5c1MbdUurA T+rXts0CXOR/cdC7yl0Ab/N5n3TgU0+PxeCVOPAPwDlzXXI8YJ0JsyMnYbFM9CNtB3/N qNK/Ve/T0GWnpHaG57D9Dm61/fIXnwjCzqGLTgr7L9yrDCupLKNItmgCzXvvoRTGW3y7 1rA1Hcj3qXXqopDX6HqTiTiVX4P+oeMDsiJ3U28+F+FjD9CN4m/M3Q34QwmQuhhgF+Gu 14SQ== X-Gm-Message-State: AOAM5318buaVLL5LDqNh2rBH4TXe1JzPj/hd8uPu+RIk94Sf0ZW2o8z2 08LIYs0av5p4VG9KZeODRs9Es1/Y2iI= X-Google-Smtp-Source: ABdhPJw6QF7fH80raIexcVSJJcWI5+80JhnZKhbcsZvXe6F2FjeBRAk7enOIJg8u2x+1lTRyEoEc3A== X-Received: by 2002:a19:f710:: with SMTP id z16mr1147543lfe.607.1614239541502; Wed, 24 Feb 2021 23:52:21 -0800 (PST) Received: from grain.localdomain ([5.18.171.94]) by smtp.gmail.com with ESMTPSA id q22sm1001473lfa.266.2021.02.24.23.52.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Feb 2021 23:52:20 -0800 (PST) Received: by grain.localdomain (Postfix, from userid 1000) id E811F56009B; Thu, 25 Feb 2021 10:52:19 +0300 (MSK) Date: Thu, 25 Feb 2021 10:52:19 +0300 To: Vladislav Shpilevoy Cc: tml Message-ID: References: <20210222182030.76232-1-gorcunov@gmail.com> <20210224153626.121506-1-gorcunov@gmail.com> <20210224153626.121506-10-gorcunov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.0.5 (2021-01-21) Subject: Re: [Tarantool-patches] [PATCH v2 09/10] wal: fix say_x format X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Wed, Feb 24, 2021 at 11:41:18PM +0100, Vladislav Shpilevoy wrote: > > say_error("Aborting transaction %llu during " > > "cascading rollback", > > - vclock_sum(&writer->vclock)); > > + (long long)vclock_sum(&writer->vclock)); > > Long long should use %lld, not %llu. I have no idea why is the format checker > silent about this. Because they are same in size and can be freely exchanged, io it is up to you hot to interpret data inside formatter as signed or unsigned, the cast must provide the _size_ of argument, not its sign.