From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 79BC970358; Tue, 16 Feb 2021 15:49:49 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 79BC970358 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1613479789; bh=VuJ0/NEj5dbBD0wrytTpVWj+enOSzdkY2JGSswvdyo4=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=iKUjnC/2CdFT5s5lpy6Cpd2HoIkvqAwE71PJrjgMPHVtXAIzSjjssGASC8W+AILuc 9hxmorhS+E/03jUccpnVhH4N6wtsq/hqG5Zk4JmLN5bg5R9/njuT1qFM55dvjmLKFJ oVLieg8/sjnVMhAkzpFhRcSTPZPSU1LmlKSiImik= Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 03F9A70358 for ; Tue, 16 Feb 2021 15:49:48 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 03F9A70358 Received: by mail-lf1-f52.google.com with SMTP id j19so15499982lfr.12 for ; Tue, 16 Feb 2021 04:49:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=goFka26WTYEEgdlgXs2RWD3qW72dttGx6DvYSrkt990=; b=AcUc+A1/QtLdHlejePP9QukrB/JLh5xBCZ5XCk7NsNHyyvNktGo4x2pDL7XobvT7RK 5O/W7c4Jh8IJG74xPtE4NklWusk4liiHol1Xog/37vz3py3Q3yNoUZn7HnD0RFjknQw6 gUocnojh1JRpIMOc3ouZ7kYPQHBJbxywyaqIsR8FshmXAblQ1V8r70OZbQB7FlcjbnSF lHZaLp9Fv7SVk5EaKchUtncZTYWGyZ2vBfDYP4cBVw4bsLuYjsHDkGfregGWqm1ylmBl zlyJ9de36fq5lhPXGnn1yI6XvscGvFoXiJFFStqCz+nazOWk+Tkyhu//QbfcOMu4K2PR nWqQ== X-Gm-Message-State: AOAM530TqckaVY/c0ffpEK+GZAij6L9M5E32GOytaLK7HFwtJZRntTAo G3kKhmWnLueal905nBO7f9C5buGm5Vs= X-Google-Smtp-Source: ABdhPJxnA6B4IRezrI4AgTBSDodtVcr1guc41was53QBTZRHTBfFNrfBTE8baq9s5XxA5LA77gZJ/g== X-Received: by 2002:ac2:4857:: with SMTP id 23mr12586156lfy.594.1613479787058; Tue, 16 Feb 2021 04:49:47 -0800 (PST) Received: from grain.localdomain ([5.18.171.94]) by smtp.gmail.com with ESMTPSA id l19sm3976688lji.53.2021.02.16.04.49.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Feb 2021 04:49:46 -0800 (PST) Received: by grain.localdomain (Postfix, from userid 1000) id 0B925560133; Tue, 16 Feb 2021 15:49:45 +0300 (MSK) Date: Tue, 16 Feb 2021 15:49:44 +0300 To: Serge Petrenko Cc: v.shpilevoy@tarantool.org, tarantool-patches@dev.tarantool.org Message-ID: References: <20210211121750.46298-1-sergepetrenko@tarantool.org> <4050015c-bf24-eac3-a890-216efab8c635@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4050015c-bf24-eac3-a890-216efab8c635@tarantool.org> User-Agent: Mutt/2.0.5 (2021-01-21) Subject: Re: [Tarantool-patches] [PATCH v2] wal: introduce limits on simultaneous writes X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Tue, Feb 16, 2021 at 03:47:09PM +0300, Serge Petrenko wrote: > > Here's an incremental diff. It's all pure refactoring with no functional > changes. > I've intdouced `journal_queue_on_append` and `journal_queue_on_complete` for > increasing and > decreasing queue length and size, and tried to remove `struct journal` > parameter from almost > every new method, except `journal_queue_set_max_size` and > `journal_queue_set_max_len` Great! Lets give this patch some time to spin around maybe we gather more comments. Looks OK to me.