From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id C272B6EC6F; Fri, 12 Feb 2021 14:46:38 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C272B6EC6F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1613130398; bh=e0L3U2SEoeG/JKWi45oKyaI1pSPSfZDboNXk/ZpbSN4=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=X1k9WVd01whSprRcDM5bAf/x93ospe6Q1CycWLbe5ZVQH9mWVsnlUAwZNC/sXRJkk PzcRaAXsKUHvT0XSDCqs449RSFVI2t7SPVbEHrpRem3Mq2aJOYSp1hige6yP2HJMIr M/NRWmutjP4M9gzoVis2UNedn3+QDfrWLxicdvnU= Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 981826EC6F for ; Fri, 12 Feb 2021 14:46:37 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 981826EC6F Received: by mail-lf1-f49.google.com with SMTP id f1so12673334lfu.3 for ; Fri, 12 Feb 2021 03:46:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=L2JIh7PgNkAzyvNxkv1SHUd/s5DZSzZ7kog+TuL1C0M=; b=aIdyaINKJcJ6O3deBfEpQftx8mX+yhAQUN/EcQzctBc+4vl5ZTkn6in/jzdCIdF6Y1 jR2KltJMd7uTLzVpTDZS/acNlbiy7o6qppvTk/mGTHqcR42lwEv2iVQfxIJ4Ynio0soX 3ohU9ByNh5dn1C8qqVTuvGp7mdN3Hf5ZxN6h3ElAcNhKbPzMooft3WUCNhZ3HIrhkIeV 3fRFOUtPBAe17o6FWxK6gMDSlgHB/pniRifr4O7ok2kohrfw6KYuiopuRMLKQiajVjT3 PTYGw/l+Cvy7AZeo1ly+gWEp7FDUGjWYNxrvMYWuwqKV8h4k2GJMRuLkpGYXD4vI00Zc u+XA== X-Gm-Message-State: AOAM531/bn2Pq3pYY+kquN6tkqLh1723uQoZBzMOXYg7vwygHMxodMxA a8DWvHSUq9+d0sj4+pA0JctOXx6BxUE= X-Google-Smtp-Source: ABdhPJyGHG9ymyIlb2cltyyOybN3vwvA1No9UH+TnowMxEG+j5OSbys4ojONxNDNBTDqiUqzskdnEg== X-Received: by 2002:a05:6512:31d2:: with SMTP id j18mr1438494lfe.661.1613130396493; Fri, 12 Feb 2021 03:46:36 -0800 (PST) Received: from grain.localdomain ([5.18.171.94]) by smtp.gmail.com with ESMTPSA id h1sm505605ljl.61.2021.02.12.03.46.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Feb 2021 03:46:35 -0800 (PST) Received: by grain.localdomain (Postfix, from userid 1000) id A25F3560077; Fri, 12 Feb 2021 14:46:34 +0300 (MSK) Date: Fri, 12 Feb 2021 14:46:34 +0300 To: Serge Petrenko Cc: v.shpilevoy@tarantool.org, tarantool-patches@dev.tarantool.org Message-ID: References: <20210212112541.27561-1-sergepetrenko@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.0.5 (2021-01-21) Subject: Re: [Tarantool-patches] [PATCH] relay: yield explicitly every N sent rows X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Fri, Feb 12, 2021 at 02:37:48PM +0300, Cyrill Gorcunov wrote: > > Serge, if I'm not missing something obvious, this row counter is > related to xstream->rows? So maybe define this type as size_t instead, > to be consistent with another occurence of WAL_ROWS_PER_YIELD. Say, > > static size_t row_cnt = 0; > ... > if (++row_cnt % WAL_ROWS_PER_YIELD == 0) > fiber_sleep(0); > > I'm fine with uint64_t as well, just out of curiosity. Ack for current version as well Cyrill