From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 336087F7C1; Wed, 1 Feb 2023 11:56:26 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 336087F7C1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1675241786; bh=UZ3rpgO9h3dZQO4seecdWSfTf7G1m0MTEXZBB/6xIvA=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=rzIyCMZwj/KMhxbV3buk//wCf6pKPt3hlTPLzyNL6g4GdkJRVA+uD4+3vM3XR1QU0 PTtZvWiKXVmQ+G+2EDncxMfW3oqY+AVxBvwIHSlY6kpD/F2j9rL0Jb+LVmJ7qK7Xou c+isl6ge2ixsaoLSmGSiXharw0FBWSEbf+BZg8jE= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 879897F7C1 for ; Wed, 1 Feb 2023 11:56:24 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 879897F7C1 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1pN8ul-0005Ph-Hm; Wed, 01 Feb 2023 11:56:24 +0300 Date: Wed, 1 Feb 2023 11:52:56 +0300 To: Igor Munkin Message-ID: References: <344EA858-7445-4DD9-8A4F-625F940614D7@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD939F4CB9F411D0C049A665BBDE0BC1BBFF81CF83F376AEBF9182A05F5380850402366739193A5B743B3F42AA9FDA3575AE6B7CBDF86AA5BF9D1480BC1B4161421 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7E357932315C0A3C4EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637CE17C7754E00FC028638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D860A68BDAFFAE756AC2A85AAFBF1F47B6117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC3A703B70628EAD7BA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735209647ADFADE5905B1F04B652EEC242312D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6A1DCCEB63E2F10FB089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34AF12ADB97C97CD892B4F3DB1E076B7DB91FB9E598022CE8D8595235EE4F92A0466724A5B019225BF1D7E09C32AA3244CD91466CF80FAA01CF5A628E900B516763E8609A02908F271927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojUFx0YIIX6pxA7Fe4pij4IQ== X-DA7885C5: 9A7181C733453FFBB2B365BCFF6BC6FB3787A67087591EB7C38C9CAD5B2879BA262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F73933AF1F914F131DBF53784B4890FDD9FD750AACC5FFB3875110FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 2/3] ci: introduce workflow for exotic builds X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Igor! Thanks for reply:)! On 01.02.23, Igor Munkin wrote: > Hi everyone, > > On 30.01.23, Sergey Kaplun wrote: > > > > > > > > > Shall we add the -DLUAJIT_ENABLE_CHECKHOOK and -DLUAJIT_SMART_STRINGS=1 since they are in Tarantool by default? > > > > -DLUAJIT_SMART_STRINGS=1 is set by default, so it's OK not to set it > > mannually. > > > > OTOH, -DLUAJIT_ENABLE_CHECKHOOK is not set by default. > > I prefer not to set it for this particular workflow, because I plan to > > use it for very specific builds (even impossible for Tarantool) for > > example with -DLUAJIT_DISABLE_JIT=ON, -DLUAJIT_DISABLE_FFI=ON flags. > > Also, this flag is not set for default LuaJIT testing, so I tried to > > make those workflows look similar. > > But if we want to add this flag for default build or testing we should > > add it for this workflow too. > > CC-ed Igor to hear his opinion. > > I'm totally for adding such workflows, but I suggest to do it in a > separate patch. Sergey, this is on you. OK, so I'll add exotic -DLUAJIT_ENBALE_CHECKHOOK job after this patch will be merged to avoid rebases. > > > > > > > > > > > > > -- > > Best regards, > > Sergey Kaplun > > -- > Best regards, > IM -- Best regards, Sergey Kaplun