From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id CD4B87F7C1; Wed, 1 Feb 2023 11:42:24 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org CD4B87F7C1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1675240944; bh=vdOH/dQ9hWOuDCXH61SWv0Z3IfbSw5DiQxDaehex8So=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=DGlalQXglLV42JotNv8S+gxOAoZqff5psouDpf7w7HxQfCJHlFPGxdqvu79sePlFY iHKceXPwWosJcs6b2SE2MWbYVco28aj4xhMRbR24RYqKJhwUeIgtPbnMhSUQWz8nL3 EEtPGmtPf0ATUnPi1UEkj7JH4iN1HFOtq2fLeoTE= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 0D8347F7C1 for ; Wed, 1 Feb 2023 11:42:24 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0D8347F7C1 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1pN8hD-0008Sp-33; Wed, 01 Feb 2023 11:42:23 +0300 Date: Wed, 1 Feb 2023 11:27:29 +0300 To: Sergey Kaplun Message-ID: References: <344EA858-7445-4DD9-8A4F-625F940614D7@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD939F4CB9F411D0C04A7D1C053D74D162CA31642CA885570F9182A05F538085040BA2949DEE4FAA91A658F44E60458DBF3C2C770DC9191A7A4AFFD8325B7C07727 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7EA3ECAD3D6C46603C2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE78AC0750F3304E924EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38B6F1F7B995052D5CE354DEC6C98FB96FBB6C4EAF254CD6A48CC7F00164DA146DAFE8445B8C89999728AA50765F7900637D0FEED2715E18529389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8B6FBD635917D924DF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8BA011DDE2B330EE6E75ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D341E08D7EE1804B76361ED5D28164E034C112A26263B47270243F1B51A2F51DC156CA273EFED8D486B1D7E09C32AA3244CDEC64886C054C4746C44F4AA279FA7436C2483212766842283B48618A63566E0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojUFx0YIIX6pxTZOdQ0ENAJQ== X-DA7885C5: FB5934DA06C1FB52B53E9B7DE534FEDB406C679BCD27CB220F12BA368979DDC9262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F73933AF1F914F131DBF5209E891755845ECAA4C23C940DBD3267A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E3365FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 2/3] ci: introduce workflow for exotic builds X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi everyone, On 30.01.23, Sergey Kaplun wrote: > > > > Shall we add the -DLUAJIT_ENABLE_CHECKHOOK and -DLUAJIT_SMART_STRINGS=1 since they are in Tarantool by default? > > -DLUAJIT_SMART_STRINGS=1 is set by default, so it's OK not to set it > mannually. > > OTOH, -DLUAJIT_ENABLE_CHECKHOOK is not set by default. > I prefer not to set it for this particular workflow, because I plan to > use it for very specific builds (even impossible for Tarantool) for > example with -DLUAJIT_DISABLE_JIT=ON, -DLUAJIT_DISABLE_FFI=ON flags. > Also, this flag is not set for default LuaJIT testing, so I tried to > make those workflows look similar. > But if we want to add this flag for default build or testing we should > add it for this workflow too. > CC-ed Igor to hear his opinion. I'm totally for adding such workflows, but I suggest to do it in a separate patch. Sergey, this is on you. > > > > > -- > Best regards, > Sergey Kaplun -- Best regards, IM