From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 2C8792BDC76; Mon, 30 Jan 2023 12:42:45 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2C8792BDC76 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1675071765; bh=j2rAyq3QyX/Bug43MOhDoqC1DKoiSLbQ2D2vsztNV0g=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=x36hIN5gCejVvHm23NWjkPSt4a2GOK2KaWOB0sUvjd/eFJHztoL/HW7WhlPJTLqEA 2K3q38jf0+syWMbjJSra/gDDvkD8ZKA3wvls0WJH7tBpkaHkfqtQME1V3fzr+OFVPk DjaHJPZTMz46oPcU2uMqH/z/zTy4G2zFUp7vbTbQ= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 2091C6ECCD for ; Mon, 30 Jan 2023 12:42:43 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2091C6ECCD Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1pMQgU-0006zv-8o; Mon, 30 Jan 2023 12:42:42 +0300 Date: Mon, 30 Jan 2023 12:39:15 +0300 To: sergos Message-ID: References: <1588326195edd86f5276ad42143043fbde46abeb.1674068996.git.skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD939F4CB9F411D0C04B066AB4AC68227AECC3DB394144B5EBF182A05F538085040FC509323BA8AEDD92CE7E3F00CC0769660D47979F6B48CC2056A605E2599C4B7 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7AD3501B5CE9C42E3EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006371E4BC0E00C009995EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38B6F1F7B995052D5CE51E0992E329416680331E8F9EFAE27B3CC7F00164DA146DAFE8445B8C89999728AA50765F7900637CA37C9946A8B9E41389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC860910C30DCD593B1F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8B08F9A42B2210255C75ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3442AF01057B6BF997B74AF04B46EC4E8678C72D97BC9DD66831D23DA778FCA36A9A1E9B3432BA445F1D7E09C32AA3244C63AC45FD502AD0697BDD181EECFFBFD7C3B3ADDA61883BB5FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojWYY/8C2LS7WieXB1AlbxDw== X-DA7885C5: A96BFD5F1D87CC2D4DFF982017BCE1CB223D5BAC35C61E2E6C34AFAEA2B798BB262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F73933AF1F914F131DBF5B77220D4796A07D0C5D890D73182478F0FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 1/3] sysprof: fix interval parsing in dual-number mode X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergos! Thanks for the review! On 26.01.23, sergos wrote: > Hi! > > Just a nit in message, LGTM. > > Sergos > > > On 18 Jan 2023, at 23:16, Sergey Kaplun wrote: > > > > When the profiling interval is parsed, `tvisnum()` is used to check that > a Fixed, thanks! > > > the given value is a number. But in case of dual-number mode this check > > returns false as far as the given value is an integer, so `tvisnumber()` > > should be used to cover both cases. > > --- > -- Best regards, Sergey Kaplun