From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B14AF70370; Thu, 26 Jan 2023 10:11:43 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B14AF70370 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1674717103; bh=2TFVwGWU1KQ/77sNIQv+Dsoo+KQn1TnkKOXFFRKHUNQ=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=SiO34DFom3S4Cw7hbcmsPUJajVCvZcq0rtZWVCNZbKDpOyxftb7or0CNVeQIEeGp9 c7WnHK12leWcIHABkIm13Bi13RNAqov0OXG59XTYqjDbbuVKkFuwLlz+5Pr/+lkVTM h5SqT39PUfaQ3KAp8Xjb5uxi5ficHfOnIfyYo9Gg= Received: from smtp58.i.mail.ru (smtp58.i.mail.ru [217.69.128.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 2D3A570370 for ; Thu, 26 Jan 2023 10:11:42 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2D3A570370 Received: by smtp58.i.mail.ru with esmtpa (envelope-from ) id 1pKwQ9-0000Gy-GW; Thu, 26 Jan 2023 10:11:41 +0300 Date: Thu, 26 Jan 2023 10:08:16 +0300 To: Maxim Kokryashkin Message-ID: References: <20230119162329.31893-1-skaplun@tarantool.org> <1674573986.547093835@f164.i.mail.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1674573986.547093835@f164.i.mail.ru> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD939F4CB9F411D0C04563E6DE9EA85E9752C3C2CBFE51DBF69182A05F538085040CDA045E9741E1DBBF54DECE6A46EFB923323975A60E893546CAC7D16E8CCED8E X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE72AC9FB60380F23AEEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006371D26D2A8652661258638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8D21DCE8337FBF2A68149FFD950219E71117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC8C7ADC89C2F0B2A5A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735200AC5B80A05675ACD2CC0D3CB04F14752D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EED76C6ED7039589DE03CEA74F0D118906D8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE3AD74539164518AE5BA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE72F88032165008D51731C566533BA786AA5CC5B56E945C8DA X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D340DAE5B306C240CF510518935223A427F35E057C49DE2D1BF254B37F37879D588B06213E1D12428E61D7E09C32AA3244CE2A3D9F61AE113228350D853D188516BE646F07CC2D4F3D8FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojSgrCHE6ee1g3toU2KMLZTg== X-Mailru-Sender: F16D9CAFEEA6770E7B6EAD4ADB3BCAF07D54C8B805FECD197564CD49BB2C1459107C7E1DDED5BCC6F2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A84198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] test: add test for `string.char('%c', 0)` X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! Thanks for the review! On 24.01.23, Maxim Kokryashkin wrote: > > Hi, Sergey! > Thanks for the patch! > LGTM, except for the single nit regarding the commit title. > I believe, it should be the `string.format` instead of `string.char`. Nice catch! Fixed! Thanks! Branch is force-pushed. > -- > Best regards, > Maxim Kokryashkin >   >   > >  > >>This patch adds the test for the commit > >>430d9f8f7ebb779948dbd43944b876b1a3f58551 ("Fix string.format("%c", > >>0)."). Although, the issue affects 2.0 branch only, there is no need to > >>fix it. Nevertheless, the test is required to avoid regressions in the > >>future. > >> > >>Part of tarantool/tarantool#8069 > >>--- > >> > >>PR: https://github.com/tarantool/tarantool/pull/8189 > >>Branch: https://github.com/tarantool/luajit/tree/skaplun/lj-378-string-format-c-null-char-full-ci > >>Issues: > >>* https://github.com/tarantool/tarantool/issues/8069 > >>* https://github.com/LuaJIT/LuaJIT/issues/378 > >> > >> .../lj-378-string-format-c-null-char.test.lua | 11 +++++++++++ > >> 1 file changed, 11 insertions(+) > >> create mode 100644 test/tarantool-tests/lj-378-string-format-c-null-char.test.lua > >> > >>diff --git a/test/tarantool-tests/lj-378-string-format-c-null-char.test.lua b/test/tarantool-tests/lj-378-string-format-c-null-char.test.lua > >>new file mode 100644 > >>index 00000000..15cefadf > >>--- /dev/null > >>+++ b/test/tarantool-tests/lj-378-string-format-c-null-char.test.lua > >>@@ -0,0 +1,11 @@ > >>+local tap = require('tap') > >>+ > >>+local test = tap.test('lj-378-string-format-c-null-char') > >>+test:plan(1) > >>+ > >>+-- Test file to check that there is no regression in > >>+-- `string.format('%c', 0)` behaviour. > >>+-- See also https://github.com/LuaJIT/LuaJIT/issues/378 . > >>+ > >>+test:is(string.format('%c', 0), '\0', 'string.format %c on null char') > >>+os.exit(test:check() and 0 or 1) > >>-- > >>2.34.1 > >  -- Best regards, Sergey Kaplun