From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Maksim Kokryashkin <max.kokryashkin@gmail.com>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] test: add test case for math.modf
Date: Fri, 3 Feb 2023 16:06:30 +0300 [thread overview]
Message-ID: <Y90G1j+oWLycn5Tp@root> (raw)
In-Reply-To: <20230203124550.47694-1-max.kokryashkin@gmail.com>
Hi, Maksim!
Thanks for the patch!
LGTM!
Side note: we can move `array_is_consistent()` check to `utils` module
later if we really need it.
--
Best regards,
Sergey Kaplun
next prev parent reply other threads:[~2023-02-03 13:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 12:45 Maksim Kokryashkin via Tarantool-patches
2023-02-03 13:06 ` Sergey Kaplun via Tarantool-patches [this message]
2023-03-02 12:31 ` sergos via Tarantool-patches
2023-03-02 15:40 ` Igor Munkin via Tarantool-patches
2023-03-09 12:14 ` Maxim Kokryashkin via Tarantool-patches
2023-03-30 17:38 ` Igor Munkin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y90G1j+oWLycn5Tp@root \
--to=tarantool-patches@dev.tarantool.org \
--cc=max.kokryashkin@gmail.com \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit] test: add test case for math.modf' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox