From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 947361BD853; Mon, 16 Jan 2023 11:10:43 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 947361BD853 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1673856643; bh=UUSMngsaKzjjzp+yKDlKiL91e+/LCzvrn5hhjjHdDZo=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=LB8Klnkood9Gxxo2/LJp1up9d+RxD8ysL8rWn9M4Fjy0IG8zul5jTTBtW4dpOzrHf Xum1VWbuqHR6H441tOTgRHgQbJr3/wPfZ7ZUb2Ona5GKBRz0yCZgPc2/NA2kVKZaij zBtmpA2IYNV0vya9oabInDL3IoDYCMkuLQyMAepg= Received: from smtpng2.i.mail.ru (smtpng2.i.mail.ru [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C3B101BD853 for ; Mon, 16 Jan 2023 11:10:41 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C3B101BD853 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1pHKZk-0006NR-WA; Mon, 16 Jan 2023 11:10:41 +0300 Date: Mon, 16 Jan 2023 10:55:50 +0300 To: Sergey Kaplun Message-ID: References: <1673565796.597008760@f475.i.mail.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD94E040F7CEBE48B4BBB17490BA8DE079758B6C1867B8FD38B182A05F5380850404C228DA9ACA6FE273500EC2465C2AC0C38E69A879B756C23AF768EC6896B220A41249BE5FC282AF6 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE74EB183AD45C8BEFBEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006371E8C7BD479B346ED8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D824EADD2E809E0371E0D3EB0B39A6D4A7117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC3A703B70628EAD7BA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520D76C6ED7039589DE618001F51B5FD3F9D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B67393CE827C55B5F775ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3454548929AF40B428DD8B62A6EACAFF6F97E0DDC9C5DA1AAA23638392730B6FA82965B6791B8542C61D7E09C32AA3244CB34CFE5D4721B7F803C9833FB46B33A9A90944CA99CF22E3927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojVTTanLM7obDOdKPPP7YlbQ== X-DA7885C5: 52A610EDA62A0BE9EC524A0005BAEACCDA935DF90C2126F396CC168233AC2124262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F73933AF1F914F131DBF50C75C48B87CECA2CA8F3D79C17321FE2A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E3365FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 1/2] ci: change runner dispatch for LuaJIT testing X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for your review! On 13.01.23, Sergey Kaplun wrote: > Hi, Igor! > > Thanks for the patch! > LGTM, with a single question below. > > On 13.01.23, Maxim Kokryashkin wrote: > > > > Hi, Igor! > > Thanks for the patch! > > LGTM, except for a few nits below. Added your tag: | Reviewed-by: Sergey Kaplun > >   > > >>"regular" ones need to be chosen for full LuaJIT testing. At the same > > >>time there is no need to use "regular" runner for LuaJIT Static analysis > > >>workflow, hence 'lightweight' label is added to list in > > >>lint.yml workflow file. > > >Shall we create the same patch for the gnumake workflow? > > I agree here. IMHO, we can use "lightweight" label for gnumake build as > far as it tests only build, so doesn't require a lot of memory. Replied to the Max thread. > > > -- > Best regards, > Sergey Kaplun -- Best regards, IM