From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 93A19241E0F; Fri, 13 Jan 2023 10:14:10 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 93A19241E0F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1673594050; bh=ZzHmaZg64MmaKp+Mr6rB+MoJEr77gg26Mfz6egvArBQ=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=i6VAGvNzzk279OxBGtyoMTVYYFbwjwQsgb1DL5bwMWc5S57wlEfZFO5yLVpwYnZ6l YU4q3mDcMs5B1zwbPsQyDoe0s9g7n+2Fz0psD/a2xE2wPe/4jcyyccpTXWd3ApTXSQ BSHsRvFC0pTgh1Omwxaeh0JxEhNPth1ND1yx7XpE= Received: from smtp16.i.mail.ru (smtp16.i.mail.ru [95.163.41.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id DC7BC164E68 for ; Fri, 13 Jan 2023 10:14:09 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org DC7BC164E68 Received: by smtp16.i.mail.ru with esmtpa (envelope-from ) id 1pGEGP-008SFW-1e; Fri, 13 Jan 2023 10:14:09 +0300 Date: Fri, 13 Jan 2023 10:10:48 +0300 To: Maxim Kokryashkin Message-ID: References: <1673565796.597008760@f475.i.mail.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1673565796.597008760@f475.i.mail.ru> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9243CDB40E273482091AB06C802711B97143EFEDC8F2F33141313CFAB8367EF908E2BE116634AD74D6099E17F8E1B7A7B67F006DE88105146BE2F121EF32A4E740C8629FDE0E8EB2A X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7922E451CE6E839B1EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006379F6495389D012EA98638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D817A826BBAE954684D5F50CC877ECD6C5117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCF1175FABE1C0F9B6A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735207B96B19DC4093321E5D25F19253116ADD2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EED76C6ED7039589DEFCB1554B277F7060D8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE3AD74539164518AE5C0837EA9F3D19764C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F79006373BC478629CBEC79DEFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34F7CC4EA888783AE025B38B47DEA1AB1650E6CB8B5B30844B5E5710CB1DD31DAE4D451C910BB84E251D7E09C32AA3244C057A766139411D909A137BAD08DA2424A995755A1445935EFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojI459hkOkW/aTLV2OJxoUxA== X-Mailru-Sender: F16D9CAFEEA6770E7B6EAD4ADB3BCAF0E04AC0959F5D2E9A716487F971B6DD43924BEFD75827F5DDF2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A84198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 1/2] ci: change runner dispatch for LuaJIT testing X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Igor! Thanks for the patch! LGTM, with a single question below. On 13.01.23, Maxim Kokryashkin wrote: > > Hi, Igor! > Thanks for the patch! > LGTM, except for a few nits below. >   > >  > >>Before the patch the all LuaJIT testing jobs were dispatched to the > >Typo: s/the all/, all/ > >>runner with the name given via strategy matrix entry. However, > >Typo: s/via/via the/ > >>more convenient way for dispatching is the triplet of the following > >Typo: s/more/a more/ > >>labels: > >>* to specify the host architecture (i.e. x86_64 or ARM64) > >>* to specify the OS family name (either Linux or macOS) > >>* 'self-hosted' to make job dispatch only to the runners from Tarantool > >>  ghacts-shared-* pool and never choose GitHub public resources. > >> > >>With the given triplet the proper runner is chosen for the particular > >>testing flavor. > >> > >>Moreover, the new 'lightweight' and 'regular' labels are also used in > >> list, since the new "lightweight" runners have been introduced > >>to ghacts-shared-* pool. There are a couple of LuaJIT tests that > >>requires more memory than provided by "lightweight" runners, so only > >Typo: s/requires/require/ > >Typo: s/than/than is/ > >  > >>"regular" ones need to be chosen for full LuaJIT testing. At the same > >>time there is no need to use "regular" runner for LuaJIT Static analysis > >>workflow, hence 'lightweight' label is added to list in > >>lint.yml workflow file. > >Shall we create the same patch for the gnumake workflow? I agree here. IMHO, we can use "lightweight" label for gnumake build as far as it tests only build, so doesn't require a lot of memory. > >> > >>Signed-off-by: Igor Munkin < imun@tarantool.org > > >>--- > >> .github/workflows/gnumake-builds-testing.yml | 20 ++------------------ > >> .github/workflows/lint.yml | 2 +- > >> .github/workflows/testing.yml | 20 ++------------------ > >> 3 files changed, 5 insertions(+), 37 deletions(-) > >> > >>diff --git a/.github/workflows/gnumake-builds-testing.yml b/.github/workflows/gnumake-builds-testing.yml > >>index ad9d5015..e5f82780 100644 > >>--- a/.github/workflows/gnumake-builds-testing.yml > >>+++ b/.github/workflows/gnumake-builds-testing.yml > >>diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml > >>index e565144c..02150922 100644 > >>--- a/.github/workflows/lint.yml > >>+++ b/.github/workflows/lint.yml > >>diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml > >>index 958f8e27..5558e3ea 100644 > >>--- a/.github/workflows/testing.yml > >>+++ b/.github/workflows/testing.yml > >>-- > >>2.34.0 > >-- > >Best regards, > >Maxim Kokryashkin > >  -- Best regards, Sergey Kaplun