From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Sergey Kaplun <skaplun@tarantool.org>, Maxim Kokryashkin <m.kokryashkin@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH] cmake: introduce CheckUnwindTables helper Date: Thu, 12 Jan 2023 17:55:23 +0300 [thread overview] Message-ID: <Y8AfWyS+wo6S7OF5@tarantool.org> (raw) In-Reply-To: <e717eaac5611b2ec46fbe8b400a1c6db796bdb1e.1673277902.git.imun@tarantool.org> I've checked the patches into all corresponding long-term branches in tarantool/luajit and bumped a new version in master, 2.10. On 09.01.23, Igor Munkin wrote: > After struggling with black voodoo magic oneliner provided by Mike Pall > in scope of e131936133c58de4426c595db2341caf5a1665b5 ("Cleanup and > enable external unwinding for more platforms.") to check whether the > target toolchain always generates unwind tables, it was decided to > implement it as a CMake function to encapsulate and comment this damn > "grep" spell. > > Signed-off-by: Igor Munkin <imun@tarantool.org> > --- > > Branch: https://github.com/tarantool/luajit/compare/imun/fix-build-for-non-bash > CI is green(*): https://github.com/tarantool/luajit/commit/e717eaa > > (*) Max, could you please check this patch on the Alpine? > > cmake/CheckUnwindTables.cmake | 114 ++++++++++++++++++++++++++++++++++ > cmake/SetTargetFlags.cmake | 18 ++---- > 2 files changed, 120 insertions(+), 12 deletions(-) > create mode 100644 cmake/CheckUnwindTables.cmake > <snipped> > -- > 2.34.0 > -- Best regards, IM
next prev parent reply other threads:[~2023-01-12 15:10 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-12-21 14:33 [Tarantool-patches] [PATCH luajit] cmake: fix build for non-bash shells Maxim Kokryashkin via Tarantool-patches 2023-01-09 15:28 ` [Tarantool-patches] [PATCH] cmake: introduce CheckUnwindTables helper Igor Munkin via Tarantool-patches 2023-01-10 10:05 ` Sergey Kaplun via Tarantool-patches 2023-01-10 11:12 ` Igor Munkin via Tarantool-patches 2023-01-10 17:36 ` Maxim Kokryashkin via Tarantool-patches 2023-01-10 19:18 ` Igor Munkin via Tarantool-patches 2023-01-12 14:55 ` Igor Munkin via Tarantool-patches [this message] 2023-01-09 15:32 ` [Tarantool-patches] [PATCH luajit] cmake: fix build for non-bash shells Igor Munkin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=Y8AfWyS+wo6S7OF5@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=imun@tarantool.org \ --cc=m.kokryashkin@tarantool.org \ --cc=skaplun@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH] cmake: introduce CheckUnwindTables helper' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox