From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Maxim Kokryashkin <max.kokryashkin@gmail.com>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] cmake: fix build for non-bash shells
Date: Mon, 9 Jan 2023 18:32:10 +0300 [thread overview]
Message-ID: <Y7wzeptRX9jyhWgs@tarantool.org> (raw)
In-Reply-To: <20221221143317.477323-1-m.kokryashkin@tarantool.org>
Max,
Thanks for your patch!
After several Mike's fixups, a couple of yours, I've finally decided to
implement this oneliner via CMake (already discussed the subj offline).
Hence, I propose to supersed this fix by my patch sent as a reply to
your message. I also add Sergey Kaplun as a reviewer, since I consider
my patch much more complex than yours and ask you to review it too.
--
Best regards,
IM
prev parent reply other threads:[~2023-01-09 15:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-21 14:33 Maxim Kokryashkin via Tarantool-patches
2023-01-09 15:28 ` [Tarantool-patches] [PATCH] cmake: introduce CheckUnwindTables helper Igor Munkin via Tarantool-patches
2023-01-10 10:05 ` Sergey Kaplun via Tarantool-patches
2023-01-10 11:12 ` Igor Munkin via Tarantool-patches
2023-01-10 17:36 ` Maxim Kokryashkin via Tarantool-patches
2023-01-10 19:18 ` Igor Munkin via Tarantool-patches
2023-01-12 14:55 ` Igor Munkin via Tarantool-patches
2023-01-09 15:32 ` Igor Munkin via Tarantool-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7wzeptRX9jyhWgs@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=imun@tarantool.org \
--cc=max.kokryashkin@gmail.com \
--subject='Re: [Tarantool-patches] [PATCH luajit] cmake: fix build for non-bash shells' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox