From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 0042F1B7A63; Tue, 10 Jan 2023 14:27:09 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0042F1B7A63 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1673350030; bh=svwxiFgk+IGVfIlT+RCGaoU8F8v1j3txvC0mkKHta5s=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=GlJ2sLqRtlX2XlShCmzrbaiVFoZLqmIGijp3DDfVGiWoyUE96gdlln7j804pVdp9r LmEmbOyYr9hyEbm3phkzqHsP9noV0y/hzYv81kKnUbMz7lKZpInB0ClhlieCLAVW4h zLH/vKmDTJsBJY0Hs8oEf1GlcrWwUq9bJWyjLjow= Received: from smtpng2.i.mail.ru (smtpng2.i.mail.ru [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 01AE01B7A63 for ; Tue, 10 Jan 2023 14:27:04 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 01AE01B7A63 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1pFCmU-0004op-SY; Tue, 10 Jan 2023 14:27:03 +0300 Date: Tue, 10 Jan 2023 14:12:13 +0300 To: Sergey Kaplun Message-ID: References: <20221221143317.477323-1-m.kokryashkin@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD90D1502B3BE350FE4864B117B15410743AC98D6963D3C670000894C459B0CD1B94353B112DD4526596E019EF9BD25B716EE83A948956CBFF14372A3FD2321C94C X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE72AC9FB60380F23AEEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063767500BC4578134A08638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8417608988CDCFB5AF3041E9BD8FBEF3A117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC974A882099E279BDA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735204B6963042765DA4BF04B652EEC242312D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6AC294AFEFA671E80089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D347D10A9FCB2A62DFE6A664479089AF746D3772D657A09A460A699FF71C48596AC23A0AA51F3AF9EE71D7E09C32AA3244C5775E06042E3900A1BA38A99DB9B4DD99CA7333006C390A0927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj9lwWVrAPIVmiow0qaXWAXw== X-DA7885C5: 5B154665D2340B9BBA4C3510937C604514A35C910B0446A4EF03B760A5DB1C45262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F73933AF1F914F131DBF5F4DADB93D0A1CEC1FC0DF6C49FF7E50CA7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E3365FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH] cmake: introduce CheckUnwindTables helper X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for your review! On 10.01.23, Sergey Kaplun wrote: > Hi, Igor! > > Thanks for the patch! > LGTM! Added your tag: | Reviewed-by: Sergey Kaplun > > > (*) Max, could you please check this patch on the Alpine? > > Should we add the Alpine build and test in our CI in the scope of this > commit or with separate one? Honestly, I don't want to make LuaJIT CI similar to Tarantool one in this context: if you commit to support the Linux-based distro zoo in our CI, feel free to extend it by yourself. I'd rather introduce FreeBSD (or another BSD distro) instead of another fancy Linux with little tweaks that differ it from the popular ones. > > > -- > Best regards, > Sergey Kaplun -- Best regards, IM