From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Sergey Kaplun <skaplun@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH] cmake: introduce CheckUnwindTables helper Date: Tue, 10 Jan 2023 14:12:13 +0300 [thread overview] Message-ID: <Y71IDZzcUwY1/596@tarantool.org> (raw) In-Reply-To: <Y704ZYKUwTQKouVL@root> Sergey, Thanks for your review! On 10.01.23, Sergey Kaplun wrote: > Hi, Igor! > > Thanks for the patch! > LGTM! Added your tag: | Reviewed-by: Sergey Kaplun <skaplun@tarantool.org> > <snipped> > > (*) Max, could you please check this patch on the Alpine? > > Should we add the Alpine build and test in our CI in the scope of this > commit or with separate one? Honestly, I don't want to make LuaJIT CI similar to Tarantool one in this context: if you commit to support the Linux-based distro zoo in our CI, feel free to extend it by yourself. I'd rather introduce FreeBSD (or another BSD distro) instead of another fancy Linux with little tweaks that differ it from the popular ones. > <snipped> > > -- > Best regards, > Sergey Kaplun -- Best regards, IM
next prev parent reply other threads:[~2023-01-10 11:27 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-12-21 14:33 [Tarantool-patches] [PATCH luajit] cmake: fix build for non-bash shells Maxim Kokryashkin via Tarantool-patches 2023-01-09 15:28 ` [Tarantool-patches] [PATCH] cmake: introduce CheckUnwindTables helper Igor Munkin via Tarantool-patches 2023-01-10 10:05 ` Sergey Kaplun via Tarantool-patches 2023-01-10 11:12 ` Igor Munkin via Tarantool-patches [this message] 2023-01-10 17:36 ` Maxim Kokryashkin via Tarantool-patches 2023-01-10 19:18 ` Igor Munkin via Tarantool-patches 2023-01-12 14:55 ` Igor Munkin via Tarantool-patches 2023-01-09 15:32 ` [Tarantool-patches] [PATCH luajit] cmake: fix build for non-bash shells Igor Munkin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=Y71IDZzcUwY1/596@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=imun@tarantool.org \ --cc=skaplun@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH] cmake: introduce CheckUnwindTables helper' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox