From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id DE25721A105; Tue, 10 Jan 2023 13:08:47 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org DE25721A105 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1673345328; bh=FQji9WzJknmFFhdAo42ZJXp3XMNEZDDSXucZo+TKOFw=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Abb7wjBCEJQ7stNOmZYDifjgX9OANHB7AwdyhZ03IUb5Y96xvBXs/5wDGfbSK3gdR Yk7aLQdsjYKz3cwSEnvnpjDa145aX1WFeUWnjyZQFyBggdeLtpD5e4SJiNHKTUfHaE 3DxqUeEr01W+jkfQnV9YQupS4TukC0sm+p9UF++8= Received: from smtp52.i.mail.ru (smtp52.i.mail.ru [94.100.177.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 67C601B7A63 for ; Tue, 10 Jan 2023 13:08:46 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 67C601B7A63 Received: by smtp52.i.mail.ru with esmtpa (envelope-from ) id 1pFBYj-0002O5-He; Tue, 10 Jan 2023 13:08:46 +0300 Date: Tue, 10 Jan 2023 13:05:25 +0300 To: Igor Munkin Message-ID: References: <20221221143317.477323-1-m.kokryashkin@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD93F1575C7510F55478FC4166FA01937987B4D334E4ABBCC06182A05F5380850404C228DA9ACA6FE271A470D09C9610B779107C80F638F173930582FA31F3B843A016AA077787D7B0F X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7492D3E4238663367EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637B24541F05F0BFC9F8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D885A174756F156A36C020DD944883E440117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCF1175FABE1C0F9B6A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735200AC5B80A05675ACD6FD1C55BDD38FC3FD2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE91ADC097FE2C3A086136E347CC761E074AD6D5ED66289B52698AB9A7B718F8C46E0066C2D8992A16725E5C173C3A84C3B88863A07377B48BBA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE741256E0470D8E12A731C566533BA786AA5CC5B56E945C8DA X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34DA1FE609583D493C19AA43FDD47B9C39BA38F0ACD1C52FA20B7B9CC9526F150A5F3D7A5E85A1D5AA1D7E09C32AA3244C2E1F12F2D4C557819FFB30E272053492A995755A1445935EFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj9lwWVrAPIVklCKIjCJCyfg== X-Mailru-Sender: F16D9CAFEEA6770E7B6EAD4ADB3BCAF05EDE7B26B03692773DBCB8F63EB5AAFA5FE9CD0FB4FA84C8F2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A84198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH] cmake: introduce CheckUnwindTables helper X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Igor! Thanks for the patch! LGTM! On 09.01.23, Igor Munkin wrote: > After struggling with black voodoo magic oneliner provided by Mike Pall > in scope of e131936133c58de4426c595db2341caf5a1665b5 ("Cleanup and > enable external unwinding for more platforms.") to check whether the > target toolchain always generates unwind tables, it was decided to > implement it as a CMake function to encapsulate and comment this damn > "grep" spell. > > Signed-off-by: Igor Munkin > --- > > Branch: https://github.com/tarantool/luajit/compare/imun/fix-build-for-non-bash > CI is green(*): https://github.com/tarantool/luajit/commit/e717eaa > > (*) Max, could you please check this patch on the Alpine? Should we add the Alpine build and test in our CI in the scope of this commit or with separate one? > > cmake/CheckUnwindTables.cmake | 114 ++++++++++++++++++++++++++++++++++ > cmake/SetTargetFlags.cmake | 18 ++---- > 2 files changed, 120 insertions(+), 12 deletions(-) > create mode 100644 cmake/CheckUnwindTables.cmake > > diff --git a/cmake/CheckUnwindTables.cmake b/cmake/CheckUnwindTables.cmake > new file mode 100644 > index 00000000..903977ad > --- /dev/null > +++ b/cmake/CheckUnwindTables.cmake > diff --git a/cmake/SetTargetFlags.cmake b/cmake/SetTargetFlags.cmake > index 1ca438f1..3b9e481d 100644 > --- a/cmake/SetTargetFlags.cmake > +++ b/cmake/SetTargetFlags.cmake > -- > 2.34.0 > -- Best regards, Sergey Kaplun