From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 7FF8317B8A5; Fri, 16 Dec 2022 11:16:21 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7FF8317B8A5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1671178581; bh=CH9SL6zzWZPHXxZGojQY62u5IASltKYly+kTqtfRK9M=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=e2ZBfbjRaDwnQItbM+40qthu1b12xCkxihqAS72fiGk+3tG3EIyBkKJGq6B5JJE6k yHGnxq464R8iV59A0yDNJ8U5lY8yH1wOhfKT0kTPdmQiusVVeGxkgppjlYOEdubAMf 3Dk0VYpvV42xup6ypcv0THfwPAkuGwRB1aKvEe1Q= Received: from smtp17.i.mail.ru (smtp17.i.mail.ru [95.163.41.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 6B51C7B11C for ; Fri, 16 Dec 2022 11:16:20 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6B51C7B11C Received: by smtp17.i.mail.ru with esmtpa (envelope-from ) id 1p65tD-00EJSJ-OZ; Fri, 16 Dec 2022 11:16:20 +0300 Date: Fri, 16 Dec 2022 11:13:02 +0300 To: sergos Message-ID: References: <20221202084220.23122-1-skaplun@tarantool.org> <1670310532.819331928@f211.i.mail.ru> <5F75F00A-7ABB-43F0-86C0-2C91F2AAF78E@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5F75F00A-7ABB-43F0-86C0-2C91F2AAF78E@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD90D1502B3BE350FE41C8ED8347A4B23AB2AE947383B9B5AA400894C459B0CD1B9C427B765669A4B42C36B857A7510F16A6BFEE19C1DE4655EA2605A7B24691806 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE78C722B68A3D10D1CEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637C8BD49B17AF1FC7C8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8C431600EBCD1AC10F697BB392CE7434C117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC9FC99A4BA45EE8B4A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520C65AC60A1F0286FECB629EEF1311BF91D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EEC24E1E72F37C03A0EA93887B71B66F2BD8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE3AD74539164518AE52D242C3BD2E3F4C6C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637AD0424077D726551EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34AC632F0BE69382F3015C854F8D4E40A488372DDE8D27F5AB858091771BBE383456D645DF0928CC1D1D7E09C32AA3244CF5A78FC8B90521DD70422A3C60026DC663871F383B54D9B3FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojP137QGfWHIx4TABKy23+OA== X-Mailru-Sender: F16D9CAFEEA6770E7B6EAD4ADB3BCAF088785730946E176AC0E42D306CF92636761A6DCDDEEF2865F2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A84198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] x64/LJ_GC64: Fix type-check-only variant of SLOAD. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergos! Thanks for the review! On 15.12.22, sergos wrote: > Hi! > > Thanks for the patch! > > LGTM with fixes after Max’s review. > > Although, as we discussed earlier I would prefer the test has > `skipcond(not ffi.abi('gc64’), 'test is GC64 only')` Discussed with Igor offline and agreed to test this code flow for GC64 and non-GC64 modes. So, ignoring. > > regards, > Sergos > > -- Best regards, Sergey Kaplun