From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>,
Maxim Kokryashkin <m.kokryashkin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit 0/2] Fix tests for LUAJIT_ENABLE_CHECKHOOK
Date: Fri, 2 Dec 2022 13:05:01 +0300 [thread overview]
Message-ID: <Y4nNzfYHxP1m/v4k@tarantool.org> (raw)
In-Reply-To: <cover.1669926435.git.imun@tarantool.org>
I've extended the series with additional patch, fixing flaky subtest in
test/tarantool-tests/misclib-getmetrics-lapi.test.lua. I failed to find
the root cause why it became flaky as a result of enabling the new
option LUAJIT_ENABLE_CHECKHOOK, but the test was implemented in a
fragile way, so its flakiness was a matter of time. Fixed now, updated
both LuaJIT branch and Tarantool PR.
On 01.12.22, Igor Munkin wrote:
> After enabling LUAJIT_ENABLE_CHECKHOOK options two tests started to fail
> due to very tight JIT engine setup. This patchset is aimed to relax JIT
> engine setup and make the tests agnostic to the introduced option.
>
> Issue: https://github.com/tarantool/tarantool/issues/7762
> Branch: https://github.com/tarantool/luajit/tree/imun/gh-7762-fix-tests-for-checkhook
> PR: https://github.com/tarantool/tarantool/pull/7787
> CI: https://github.com/tarantool/luajit/commit/ba9d9c8
>
> Igor Munkin (2):
> test: relax JIT setup in lj-430-maxirconst test
> test: relax JIT setup in misc.getmetrics test
>
> .../lj-430-maxirconst.test.lua | 23 +++++++++++--------
> .../misclib-getmetrics-capi.test.lua | 7 ++++--
> .../misclib-getmetrics-lapi.test.lua | 7 ++++--
> test/tarantool-tests/utils.lua | 9 ++++++++
> 4 files changed, 33 insertions(+), 13 deletions(-)
>
> --
> 2.34.0
>
--
Best regards,
IM
next prev parent reply other threads:[~2022-12-02 10:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 20:28 Igor Munkin via Tarantool-patches
2022-12-01 20:28 ` [Tarantool-patches] [PATCH luajit 1/2] test: relax JIT setup in lj-430-maxirconst test Igor Munkin via Tarantool-patches
2022-12-05 7:52 ` Sergey Kaplun via Tarantool-patches
2022-12-05 21:33 ` Igor Munkin via Tarantool-patches
2022-12-05 10:47 ` Maxim Kokryashkin via Tarantool-patches
2022-12-05 21:34 ` Igor Munkin via Tarantool-patches
2022-12-01 20:28 ` [Tarantool-patches] [PATCH luajit 2/2] test: relax JIT setup in misc.getmetrics test Igor Munkin via Tarantool-patches
2022-12-05 7:57 ` Sergey Kaplun via Tarantool-patches
2022-12-05 21:40 ` Igor Munkin via Tarantool-patches
2022-12-05 10:52 ` Maxim Kokryashkin via Tarantool-patches
2022-12-05 21:40 ` Igor Munkin via Tarantool-patches
2022-12-02 10:01 ` [Tarantool-patches] [PATCH luajit 3/2] test: remove TAP side effects in getmetrics tests Igor Munkin via Tarantool-patches
2022-12-05 8:01 ` Sergey Kaplun via Tarantool-patches
2022-12-05 21:46 ` Igor Munkin via Tarantool-patches
2022-12-05 11:06 ` Maxim Kokryashkin via Tarantool-patches
2022-12-05 21:47 ` Igor Munkin via Tarantool-patches
2022-12-02 10:05 ` Igor Munkin via Tarantool-patches [this message]
2022-12-12 9:42 ` [Tarantool-patches] [PATCH luajit 0/2] Fix tests for LUAJIT_ENABLE_CHECKHOOK Igor Munkin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4nNzfYHxP1m/v4k@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=imun@tarantool.org \
--cc=m.kokryashkin@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit 0/2] Fix tests for LUAJIT_ENABLE_CHECKHOOK' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox