From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 4093ACDDCE; Tue, 6 Dec 2022 01:01:38 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4093ACDDCE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1670277698; bh=7lY9OlZkkaTkNKxVtCyuyFHWI0gaDmfjVhpXHQ3Q0GU=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=wGFgO3KlTGRI6qMYbtdN3oyiVa8p3q8UF9D5wkyRuJQk5z151iXdp2Cr0W/E2512e fOe2w0H+89TbYYfJHkEMmBxxGg+2PzwEi98kRy4Z9jBbj4bqwsRNTEEpLfpiK+PPKT K+k8VEm+ParZqaxFggGlBUrGwdKmo7AfHTW/6+y0= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 4B4B37036F for ; Tue, 6 Dec 2022 01:01:37 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4B4B37036F Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1p2JWq-0003Um-9y; Tue, 06 Dec 2022 01:01:36 +0300 Date: Tue, 6 Dec 2022 00:47:41 +0300 To: Maxim Kokryashkin Message-ID: References: <747403a67925a8c09148cd10ea3514b5f6766395.1669926435.git.imun@tarantool.org> <1670238411.994619745@f151.i.mail.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1670238411.994619745@f151.i.mail.ru> X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD908190A22B884CF14F728BD2D4F82E7258B41E11569A987E5182A05F53808504011EAB3875EA287731FE39A6B709BA19AA4E736E44614F811581CEAA6965C4ACD X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE712EB008F780777E9EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006378010A306A5B6F90A8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D86327B08EEA813EF49E09025C41015968117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCF1175FABE1C0F9B6A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520C24E1E72F37C03A0E5D25F19253116ADD2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6D0C9BB9AE6BD5D69089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34A9873270276D43347E3A9FAEAE181202B96BC06C45EF48D17A11EB16D2081C73ED7104546C1A5D941D7E09C32AA3244C496098B3D9F3023192AD03F030C03D97D08D48398F32B4A6927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojniwsktXAgUNIs8v6XROo/Q== X-DA7885C5: 00FFA21A99A48F4F6CBA3FAB1619AAC30F0DC29ED2264625A8FE59D20AD0454A262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F73933AF1F914F131DBF5CF634D14E887B8502464B349EB3CED0EA7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E3365FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 3/2] test: remove TAP side effects in getmetrics tests X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Max, Thanks for your review! On 05.12.22, Maxim Kokryashkin wrote: > > Hi, Igor! > Thanks for the patch! > LGTM, except for the nits Sergey has already mentioned > and the two additional nits below. Added your tag: | Reviewed-by: Maxim Kokryashkin All nits are fixed. >   > >-- > >Best regards, > >Maxim Kokryashkin -- Best regards, IM