From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 48945158CE7; Mon, 5 Dec 2022 11:04:24 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 48945158CE7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1670227464; bh=2lfgxuSjSxvasGUbaXkkr6ELV9Fz4klCnBxHfyt0sUg=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=ZoqItU8+0fInU8XnptXeYoRC3WCIGDlGL6s71DnBncfeXnzUrXMLIaDUxP6D4J5e+ QuAzfK6hJkpNtdPdyjygV11a7WxDjzh0EfW403hkXrOATaSJJ9kMa7QvTkDjiQTJG1 eudf15cRvT06zLZ6IHryYhWACs6dWtU1nk+q6E3Q= Received: from smtp40.i.mail.ru (smtp40.i.mail.ru [95.163.41.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 3A3B1158CE7 for ; Mon, 5 Dec 2022 11:04:23 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3A3B1158CE7 Received: by smtp40.i.mail.ru with esmtpa (envelope-from ) id 1p26Sc-002adY-BN; Mon, 05 Dec 2022 11:04:22 +0300 Date: Mon, 5 Dec 2022 11:01:08 +0300 To: Igor Munkin Message-ID: References: <747403a67925a8c09148cd10ea3514b5f6766395.1669926435.git.imun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <747403a67925a8c09148cd10ea3514b5f6766395.1669926435.git.imun@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD908190A22B884CF14ED37B92A3B9588C6C18087BAA9678AAF182A05F538085040CA4A1606861D27119DAB4EEB1C6781C26D08F39495D5DB9C8C75FE0AF510CDF0 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE77603ADE015AF816DEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637D7F1BE85E7B0CA818638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D84588444395A255549DB317F26E33B255117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC974A882099E279BDA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520902A1BE408319B29F04B652EEC242312D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE902A1BE408319B297C6FCE95544A9834D8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE3AD74539164518AE59735652A29929C6CC4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637BBEA499411984DA1EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3472E5ECC12A9739C18252CC8F895BD74C676321BB192A3D1EFA18FBE6F352520F469EB02ECAFBA1841D7E09C32AA3244C49CBB608CE77393A8B8CFC18CFF773BE69B6CAE0477E908DFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojniwsktXAgUOuhqpQBaDcPw== X-Mailru-Sender: F16D9CAFEEA6770E7B6EAD4ADB3BCAF0466005252F2036955ECC935CD83D18E81EEA671B0A983BD9F2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A84198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 3/2] test: remove TAP side effects in getmetrics tests X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Igor! Thanks for the patch! LGTM, except a few nits regarding the commit message. On 02.12.22, Igor Munkin wrote: > Sometimes TAP functions become hot spots for JIT compiler and the > corresponding traces spoils test assertions with their side effects. Typo: s/spoils/spoil/ > To avoid such misbehaviour and fix fragile test, is > explicitly called in this particular case. There is no need to fix the > corresponding test for Lua C API interface, since there is no TAP Typo: s/Lua C API/the Lua C API/ Typo: s/is/are/ > helpers used to check whether is counted right. There > is also no need to fix other subtests nearby, since their assertions are > no affected by TAP helpers side effects. > > Relates to tarantool/tarantool#7762 > > Signed-off-by: Igor Munkin > --- > -- > 2.34.0 > -- Best regards, Sergey Kaplun