From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 997D1158CE7; Mon, 5 Dec 2022 11:00:26 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 997D1158CE7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1670227226; bh=KUeV7HciK8+h3B1Rhp4cnKbv6exqmBg3ROSskgBkgBw=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=QdwZrh1ln35yOgeF9GCzTKrlrWedCpXm//cz/Xvced+c15Td4V6AeTv4x7a3iROMc Ov+bk4knIwDqkeHZ+kBlRJ8i8BnzDvZZDmADqWUDukwqXucHx3uz6qHJl2IFN2G30M Gwtzmh7jUqCuGNJcNtvtxDm3R+3aP+H+WJpW5rgE= Received: from smtp60.i.mail.ru (smtp60.i.mail.ru [217.69.128.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E05DD357D1 for ; Mon, 5 Dec 2022 11:00:25 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E05DD357D1 Received: by smtp60.i.mail.ru with esmtpa (envelope-from ) id 1p26Om-0007Z4-Vb; Mon, 05 Dec 2022 11:00:25 +0300 Date: Mon, 5 Dec 2022 10:57:11 +0300 To: Igor Munkin Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD908190A22B884CF14CD3D33834FD67854335A9BD4327CD189182A05F53808504028492EEEB9C51265FF83F696239F2602A9F72666AA946D8DD846A03C772DDE45 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7C6068CE86C2B75F5EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637802D3462438662818638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8D7222DE8CA206C1E6BB4B7D72A2D5AD2117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC60CDF180582EB8FBA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520902A1BE408319B29E5D25F19253116ADD2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE0AC5B80A05675ACD9100238FE36DC7A2D8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE3457EE4B4996FC546040F9FF01DFDA4A8C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637BBEA499411984DA1EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34697E0FA301E2821510B28CC0E2C5901CE0345B8F405B8D8CFE49DACB87BE1FAF9F6FC31A1ED7419C1D7E09C32AA3244C78BD5BF4BA5E3FBDF10B77A2175DCC615A1673A01BA68E40FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojniwsktXAgUN7w+n1bSMA2A== X-Mailru-Sender: F16D9CAFEEA6770E7B6EAD4ADB3BCAF0503C1C6127C1BB00184325612DC4F3D5466EB8962DF4C8D8F2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A84198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 2/2] test: relax JIT setup in misc.getmetrics test X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Igor! Thanks for the patch! LGTM, except a single nit regarding the commit message. On 01.12.22, Igor Munkin wrote: > To test whether metric is counted right for side > exits JIT engine parameter is tighted to prevent side trace > compilation (considering being used for the corresponding > branch of execution, the side trace will try to compile with stitching). > However, if test is run on the platform configured with the option Typo: s/test/the test/ > LUAJIT_ENABLE_CHECKHOOK enabled, the resulting trace exceeds the > hardcoded limit and the metric is miscounted due to this new > trace. To resolve this issue limit is set to the maximum > amount of IRRef in the trace, preventing trace compilation for any > LuaJIT configuration. > > Relates to tarantool/tarantool#7762 > > Signed-off-by: Igor Munkin > --- > test/tarantool-tests/misclib-getmetrics-capi.test.lua | 7 +++++-- > test/tarantool-tests/misclib-getmetrics-lapi.test.lua | 7 +++++-- > test/tarantool-tests/utils.lua | 9 +++++++++ > 3 files changed, 19 insertions(+), 4 deletions(-) > > -- > 2.34.0 > -- Best regards, Sergey Kaplun