From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id CEC71158CE0; Mon, 5 Dec 2022 10:56:09 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org CEC71158CE0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1670226969; bh=QVjcnWiGlgvKMUdv1q4KF9fEHO0GAr3QVshaoDKUo7Q=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=L6yxA4fXCCQ06VYCM8cKtmT1eJs5osG5rd3c+1LjjKWVD0mj9Gmf/JegEWz9YX7pb ocbi2hMVUdpbyuG80EUwfBRo8/AAIGhFWt9lNqltdpOahKGc5/tTtaLkV4JyxGo8DO 4i/AkesS+t5KWZ8UoYni9xaBRR9bA8GwbyHbhAMY= Received: from smtp35.i.mail.ru (smtp35.i.mail.ru [95.163.41.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 1469A357D1 for ; Mon, 5 Dec 2022 10:56:08 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1469A357D1 Received: by smtp35.i.mail.ru with esmtpa (envelope-from ) id 1p26Kd-00GUyQ-AQ; Mon, 05 Dec 2022 10:56:07 +0300 Date: Mon, 5 Dec 2022 10:52:53 +0300 To: Igor Munkin Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD908190A22B884CF141FBA3A6FBB18594359F79D12ABF91FD1182A05F538085040582C909BC79FABCF0C2EA397246569B04075893AD3984409DCC962DC69B26380 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7FCFCB92DA8654BB0EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637B100969577675F2D8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D86D4B93C7FCEB60AC26B23FF0C1AE4251117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCC908CD1B87A134A2A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520C65AC60A1F0286FECB629EEF1311BF91D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE902A1BE408319B294D0DA9BD313A0613D8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE3AD74539164518AE56136E347CC761E07C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637BBEA499411984DA1EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34D95739AEDB3821B4AAEB00FE66B7805B21BF1B9B43F9418292CFAC32F694D5B00DFE5813483F318C1D7E09C32AA3244C7544F8F9971CF0EA09C9F88920EFA1BD3FD9C8CA1B0515E0FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojniwsktXAgUMCCyjk0FTtBA== X-Mailru-Sender: F16D9CAFEEA6770E7B6EAD4ADB3BCAF01152695A743F82DDF949C0ED57761FAF3607383EE86143FCF2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A84198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 1/2] test: relax JIT setup in lj-430-maxirconst test X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Igor! Thanks for the patch! LGTM, just several nits regarding the commit message. On 01.12.22, Igor Munkin wrote: > JIT engine setup in tarantool-tests/lj-430-maxirconst.test.lua is too > tight for the build with LUAJIT_ENABLE_CHECKHOOK option enabled. > Originally test limits value with 3 for the default IRRef > constants set: nil, true, false. However, with LUAJIT_ENABLE_CHECKHOOK > enabled there are three more auxiliary IRRef constants for the internal Typo: s/enabled/enabled,/ > purposes. Hence, the test is reimplemented the following way: > * The first trace for the empty function is recorded > * The number of IRRef constants is obtained via > * parameter is set to this value > * The second trace for the function with a single local variable, > initialized with a constant, fails to record > > As a result there is no need to explicitly respect any configuration. Typo: s/As a result/As a result,/ > > Relates to tarantool/tarantool#7762 > > Signed-off-by: Igor Munkin > --- > .../lj-430-maxirconst.test.lua | 23 +++++++++++-------- > 1 file changed, 14 insertions(+), 9 deletions(-) > 2.34.0 > -- Best regards, Sergey Kaplun