From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id DF93E7B11C; Thu, 24 Nov 2022 15:00:08 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org DF93E7B11C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1669291209; bh=Ky47dkn+eMQUShenxrhxFXi60z+x32eDhDbCWj1kR1A=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=uVVz9pybyU3v4ElIL06NRlhUEi1QdSerwQDb6+C2/hIgoKoggCq3s31HiFCehbLi4 w6QN8qkkCcmb/XPgJ+32cIsUlXB83mdY2MovL37RhCPvZEBuQYMq0tORnziXcgtzSa POW7/JQilQvyEQ25jNGGuUKytkHOX68C2cX4EBNM= Received: from smtp52.i.mail.ru (smtp52.i.mail.ru [94.100.177.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 608D07B11C for ; Thu, 24 Nov 2022 15:00:07 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 608D07B11C Received: by smtp52.i.mail.ru with esmtpa (envelope-from ) id 1oyAti-0007d4-D1; Thu, 24 Nov 2022 15:00:07 +0300 Date: Thu, 24 Nov 2022 14:56:57 +0300 To: Maksim Kokryashkin Message-ID: References: <20221028092638.11506-1-max.kokryashkin@gmail.com> <20221028092638.11506-8-max.kokryashkin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221028092638.11506-8-max.kokryashkin@gmail.com> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9D4445358DD2C13E2C6431B3E3B0C5529FBB459BEA059C20C182A05F538085040DF890ED55068B5AE623448BE1967E7BF2C40C037D27249C59655E4A59050DAFA X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE75AD53DF1D86BACA3EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006378D70459434292EC88638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8F3D271AA19AF18030D2CA6C6A592F7A6117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC974A882099E279BDA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520C65AC60A1F0286FE6FD1C55BDD38FC3FD2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE042285CD7A5C321F81C726BC2B329815D8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE3F8BD4E506CFA3D889735652A29929C6CC4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F79006379FC65886B7F75608EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D343D1F112031EF3D629FC52E4004CA86F6180099F8B048CFB6E34A8AD2E190EB975FA2188BF8AE1E761D7E09C32AA3244C64C559864F5AE2BF2B32E3CE574E4C9C33C9DC155518937F927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojZo+qSBrEvGRWurOqkAumLw== X-Mailru-Sender: F6248FDC0389C51188CF133EE5DC084F735A591D3A8A8CE47E94106DDB1464C6B7CBEF92542CD7C88B0A2698F12F5C9EC77752E0C033A69E86920BD37369036789A8C6A0E60D2BB63A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v4 7/8] Fix build with busybox grep. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maksim! Thanks for the patch! LGTM, with a single nit below. On 28.10.22, Maksim Kokryashkin wrote: > From: Mike Pall > > Reported by ymph. > > (cherry picked from commit 66563bdab0c7acf3cd61dc6cfcca36275951d084) > > Busybox implementation of grep doesn't have the `-U` option, but it > has the option to treat the binary as a text file, so that case is Minor: the `-a` option > provided as an alternative. > > Maxim Kokryashkin: > * added the description for the problem and updated the CMake > > Needed for tarantool/tarantool#6096 > Part of tarantool/tarantool#7230 > --- > cmake/SetTargetFlags.cmake | 2 +- > src/Makefile.original | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/cmake/SetTargetFlags.cmake b/cmake/SetTargetFlags.cmake > index 943a3152..8abb6288 100644 > --- a/cmake/SetTargetFlags.cmake > +++ b/cmake/SetTargetFlags.cmake > diff --git a/src/Makefile.original b/src/Makefile.original > index 4d7cda3e..2d014e43 100644 > --- a/src/Makefile.original > +++ b/src/Makefile.original > -- > 2.37.0 (Apple Git-136) > -- Best regards, Sergey Kaplun