From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id F0F937B11C; Thu, 24 Nov 2022 14:52:19 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org F0F937B11C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1669290740; bh=3k2bAN+h3l3HTUorfHtZ6QADMGwlVsO+hPSVQ9gLvaM=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=mBmnFxmxvZ4bKD7Mp9ddIEipbebwZe6gqmYUVkBt6cPYq8YQp9tUty1nYk2yNxNcc Rp4/auobkY9tLMmFZVp+uDDu/wa76/C03tbQ2CnvYySdRVm9JYdAVxTVaoEHMHFikV cUHtTWqtoxeVXDK0xtmoGEbg4bjEhTM26GSIVkxw= Received: from smtp48.i.mail.ru (smtp48.i.mail.ru [94.100.177.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 7CEEC7B11C for ; Thu, 24 Nov 2022 14:52:18 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7CEEC7B11C Received: by smtp48.i.mail.ru with esmtpa (envelope-from ) id 1oyAm9-0003zQ-Ne; Thu, 24 Nov 2022 14:52:18 +0300 Date: Thu, 24 Nov 2022 14:49:08 +0300 To: Maksim Kokryashkin Message-ID: References: <20221028092638.11506-1-max.kokryashkin@gmail.com> <20221028092638.11506-7-max.kokryashkin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221028092638.11506-7-max.kokryashkin@gmail.com> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9D4445358DD2C13E2A648C63A9EB10D4910BE70C51361DC00182A05F538085040FE47DC5FBA46A6A1F62EBC993BDD106FC0ED86C0D56506A9781857182EC1E7C7 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE727FD6E7FC3A8F857EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006372521E7C1CE72986C8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8CCA37144FAB261FBD2C4197EBAE3466A117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC8C7ADC89C2F0B2A5A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520437C869540D2AB0FE5D25F19253116ADD2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE042285CD7A5C321F81C726BC2B329815D8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE3F8BD4E506CFA3D889735652A29929C6CC4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F79006377F02F59195295693EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34D8C933888226C8412B218A8EEB498E0B4869150F948303C8DEC458F05F266564CDC876C2964070201D7E09C32AA3244C6FD75588DABA55D129194B1353D1036FA995755A1445935E927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojZo+qSBrEvGRxbymGPHElZg== X-Mailru-Sender: F6248FDC0389C51188CF133EE5DC084F607F0E9E9589DA9A32DA2D0685CBE3C2B7CBEF92542CD7C88B0A2698F12F5C9EC77752E0C033A69E86920BD37369036789A8C6A0E60D2BB63A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v4 6/8] BSD: Fix build with BSD grep. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maksim! Thanks for the patch! LGTM, with a single nit below. On 28.10.22, Maksim Kokryashkin wrote: > From: Mike Pall > > Thanks to carlocab. > > (cherry picked from commit b9d523965b3f55b19345a1ed1ebc92e431747ce1) > > The `-U` option makes grep process the temporary binary file as > a binary instead of text, meaning that its contents are passed I suggest to clarify this part like the following: | instead of as ASCII text with `-a` option set > to grep verbatim. > > Maxim Kokryashkin: > * added the description for the problem and updated the CMake > > Needed for tarantool/tarantool#6096 > Part of tarantool/tarantool#7230 > --- > cmake/SetTargetFlags.cmake | 2 +- > src/Makefile.original | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/cmake/SetTargetFlags.cmake b/cmake/SetTargetFlags.cmake > index d99e1f9a..943a3152 100644 > --- a/cmake/SetTargetFlags.cmake > +++ b/cmake/SetTargetFlags.cmake > diff --git a/src/Makefile.original b/src/Makefile.original > index 5826a56a..4d7cda3e 100644 > --- a/src/Makefile.original > +++ b/src/Makefile.original > -- > 2.37.0 (Apple Git-136) > -- Best regards, Sergey Kaplun