From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id EE0B7B8834; Thu, 24 Nov 2022 10:46:21 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org EE0B7B8834 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1669275982; bh=3GNPQs24NbqlWZTvxvZH/3TIWrnDIm+Ae0tTe8bhbQ4=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Z/4NvbxKot0gLtCLq6FL4s+NoF2HvMbf6LJ9keqv5oECOCBpfcX4PSlOKZzy6hvEL aBG+Rsi+ctejwUFF7QwRwXSUfNlOAs2Z5ChZsaoF8mtD8bX279t8jPPkQXo5Le98do VdPuMZvutEdFo2oDpM1svkXw7N0tG9EdPsF41bKg= Received: from smtp60.i.mail.ru (smtp60.i.mail.ru [217.69.128.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 36298B8801 for ; Thu, 24 Nov 2022 10:46:20 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 36298B8801 Received: by smtp60.i.mail.ru with esmtpa (envelope-from ) id 1oy6w7-0001rf-8L; Thu, 24 Nov 2022 10:46:19 +0300 Date: Thu, 24 Nov 2022 10:43:09 +0300 To: Maxim Kokryashkin Message-ID: References: <20221111101948.6773-1-m.kokryashkin@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221111101948.6773-1-m.kokryashkin@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9D4445358DD2C13E2C6431B3E3B0C5529FBB459BEA059C20C182A05F538085040CC8568A50C9B54FC456D4B2680BCB09EECD36ABB9CA6DABF297D23F532772731 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE76D34FAA3D8B31588C2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE77C1346FE4B18DC51EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38B8859CA687ABA27BACD598D84284FD693030825097A154AD1CC7F00164DA146DAFE8445B8C89999728AA50765F7900637F6B57BC7E64490618DEB871D839B7333395957E7521B51C2DFABB839C843B9C08941B15DA834481F8AA50765F79006379BABF3D50D9A3D87389733CBF5DBD5E9B5C8C57E37DE458BD9DD9810294C998ED8FC6C240DEA76428AA50765F7900637B4C9D997413845C7D81D268191BDAD3DBD4B6F7A4D31EC0BEA7A3FFF5B025636D81D268191BDAD3D78DA827A17800CE7AAD1B76486BE9DA4EC76A7562686271ED91E3A1F190DE8FD2E808ACE2090B5E14AD6D5ED66289B5259CC434672EE63711DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C3ADE50F0DA4A4E48C35872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D342B94C1DAF75C4D22B742F5DFD23EC98DEA902C4BF94899F6F32C40A172D096A3FDADBACD9995DD761D7E09C32AA3244C06AFBE4E8ADF5B52912A2E6EB842AEA124AF4FAF06DA24FD927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojZo+qSBrEvGTLais/szkEtw== X-Mailru-Sender: F6248FDC0389C51188CF133EE5DC084F482F88BDD5D48BD0BBB5F17F2A79456BB7CBEF92542CD7C88B0A2698F12F5C9EC77752E0C033A69E86920BD37369036789A8C6A0E60D2BB63A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] GC64: enable sysprof support X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! Thanks for the patch! LGTM, with a single nit regarding the commit message. On 11.11.22, Maxim Kokryashkin wrote: > This patch reverts changes introduced via commit > 71e7020637bb15024ceb7e93ce66b61870567339 ('GC64: disable > sysprof support'), fixing the incorrect behavior in vm Typo: s/in vm/in the VM/ > by adding the `LJ_HASSYSPROF` flag to the DynASM flags. Nice catch! > > Resolves tarantool/tarantool#7919 > Related to tarantool/tarantool#781 > --- > Issue: https://github.com/tarantool/tarantool/issues/7919 > Branch: https://github.com/tarantool/luajit/tree/fckxorg/gh-7919-sysprof-gc64 > PR: https://github.com/tarantool/tarantool/pull/7922 > > cmake/SetDynASMFlags.cmake | 5 +++ > src/lj_arch.h | 2 +- > src/lj_obj.h | 2 + > src/vm_x64.dasc | 42 ++++++++++++++----- > src/vm_x86.dasc | 8 ++++ > .../misclib-sysprof-capi.test.lua | 7 ++-- > .../misclib-sysprof-lapi.test.lua | 5 +-- > 7 files changed, 52 insertions(+), 19 deletions(-) > > diff --git a/cmake/SetDynASMFlags.cmake b/cmake/SetDynASMFlags.cmake > diff --git a/src/lj_arch.h b/src/lj_arch.h > diff --git a/src/lj_obj.h b/src/lj_obj.h > diff --git a/src/vm_x64.dasc b/src/vm_x64.dasc > diff --git a/src/vm_x86.dasc b/src/vm_x86.dasc > diff --git a/test/tarantool-tests/misclib-sysprof-capi.test.lua b/test/tarantool-tests/misclib-sysprof-capi.test.lua > diff --git a/test/tarantool-tests/misclib-sysprof-lapi.test.lua b/test/tarantool-tests/misclib-sysprof-lapi.test.lua > -- > 2.38.0 > -- Best regards, Sergey Kaplun