From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 2FBEF6FFCC; Thu, 10 Nov 2022 09:30:54 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2FBEF6FFCC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1668061854; bh=4478c9WJ2pSUS9v33x/JtF29MQ2ZQ3wiHUW1RMN8KrM=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=OgSYRrCKPswiBUECcOisccKebZ7S3cTYHEIjfBPQM3qUycqaHM7d03MD46EUXNZrE ZjzIddP8LLwEQOc+NwLfolV2qi/HSy/LeG6vbYKuTGDAMzsVU7i1S9LbFhJgBi1G/o AC9iumBWtvtIyblwrYvROZHuD4LMim7moWw6WObI= Received: from smtp55.i.mail.ru (smtp55.i.mail.ru [217.69.128.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 6F3EE6FFCC for ; Thu, 10 Nov 2022 09:30:52 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6F3EE6FFCC Received: by smtp55.i.mail.ru with esmtpa (envelope-from ) id 1ot15P-0008Hq-Bh; Thu, 10 Nov 2022 09:30:51 +0300 Date: Thu, 10 Nov 2022 09:27:46 +0300 To: Maxim Kokryashkin Message-ID: References: <20221019123730.25039-1-skaplun@tarantool.org> <1667026151.120548758@f533.i.mail.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1667026151.120548758@f533.i.mail.ru> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD95B5D117648C7F15261B311350E21256AD882F2D0CAB14547182A05F538085040240400BAD0C3A42DBBCB889E79A0289B1B155842DDC25820C2F54DAF21B64099 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE70A10A23A3B64B805EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006377CC130305260E47D8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8A3A7D8FA0F341DF4F85DFAB7D35464A7117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCF80095D1E57F4578A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520D76C6ED7039589DE2CC0D3CB04F14752D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE599709FD55CB46A67F16001415B11694D8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE32A336C651863509103F1AB874ED89028C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637A8A59EE88DA1D479EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34A5BF8FA0BD61F994DDD0D73B6AE4E608C3D077CFE0A6556DA83FEBF5310529665A5F7F30E890914C1D7E09C32AA3244CACA50EC32E8C9B1FCD7C965D4D77C9ECC86C126E7119A0FEFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojDvKINbZCEhIa++Dd5KrTvQ== X-Mailru-Sender: 87D5297B137A96FE4AECA001A08BCABA05213D8C6BDAB6E86F8EA795DFA4F3604CE8BAE898338743525762887713E5F1475755348978188EF9D3679FA3DE6E791CC59163FFD68303B0DAF586E7D11B3E67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] Save trace recorder state around VM event call.\ X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! Thanks for the review! On 29.10.22, Maxim Kokryashkin wrote: > > Hi! > Thanks for the patch! > Please consider my comment below. > >  > >>Hi, Sergos! > >> > >>Thanks for the review! > >> > >>On 25.10.22, sergos wrote: > >>> Hi! > >>> > >>> Thanks for the patch! > >>> > >>> Some comments on the commit message and the test showed flaky behavior, > >>> it failed only 2 times out of 10 runs using the > >>> Tarantool 2.11.0-entrypoint-637-gdd7d46af3 on a > >>> Darwin s-ostanevich2 22.1.0 Darwin Kernel Version 22.1.0 > >> > >>OMG, `tap` in tarantool is slightly different so the test is flaky. > >> > >>Fixes with increasing amount of calls of `fibb()` function. > >> > >>Also, removes `jit.bc.dump()` output. > >> > >>See the iterative patch below. > >>=================================================================== > >>diff --git a/test/tarantool-tests/gh-6782-stitching-in-vmevent-handler.test.lua b/test/tarantool-tests/gh-6782-stitching-in-vmevent-handler.test.lua > >>index b5146f70..475d9200 100644 > >>--- a/test/tarantool-tests/gh-6782-stitching-in-vmevent-handler.test.lua > >>+++ b/test/tarantool-tests/gh-6782-stitching-in-vmevent-handler.test.lua > >>@@ -18,11 +18,16 @@ local function fibb(n) > >>   return n < 2 and n or fibb(n - 1) + fibb(n - 2) > >> end > >>  > >>+local function empty() end > >> -- Compile `jit.bc` functions, that are used in vmevent handler. > >>-require('jit.bc').dump(loadstring(string.dump(fibb))) > >>+require('jit.bc').dump(loadstring(string.dump(fibb)), { > >>+ write = empty, > >>+ close = empty, > >>+ flush = empty, > >>+}) > >>  > >> -- Here we dump (to /dev/null) info about `fibb()` traces and run > >> -- `jit.bc` functions inside. > >>-test:ok(fibb(0) == 0, 'run compiled function inside vmevent handler') > >>+test:ok(fibb(2) == 1, 'run compiled function inside vmevent handler') > >>  > >> os.exit(test:check() and 0 or 1) > >>=================================================================== > >That test passes even without the patch on M1 LJ_64, LJ_GC64, LJ_DUALNUM. > > I suppose, that this is not the huge problem. Maybe some traces for `jit.bc` are not compiled on M1. The fact that the test fails on x86/x64 !GC64 is enough for me (at least it is how bug has been detected). > >  > >-- > >Best regards, > >Maxim Kokryashkin > >  -- Best regards, Sergey Kaplun