From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Maxim Kokryashkin <max.kokryashkin@gmail.com> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH luajit] sysprof: disable proto and trace dumps in default Date: Fri, 11 Nov 2022 11:54:05 +0300 [thread overview] Message-ID: <Y24NrWFKPbtsG6mU@tarantool.org> (raw) In-Reply-To: <20220612185220.502537-1-m.kokryashkin@tarantool.org> Max, I've checked the patch into all required long-term branches in tarantool/luajit and bumped a new version in master and 2.10. On 12.06.22, Maxim Kokryashkin wrote: > There is no need to dump proto or trace information for sysprof > in the default mode. Moreover, attempts to do so will lead to > segmentation fault due to uninitialized buffer. This commit > disables proto and trace dumps in the default mode. > > Resolves tarantool/tarantool#7264 > --- > PR: https://github.com/tarantool/tarantool/pull/7265 > Branch: https://github.com/tarantool/luajit/tree/fckxorg/gh-7264-dump-proto-default-mode > > src/lj_sysprof.c | 4 +- > ...4-add-proto-trace-sysprof-default.test.lua | 58 +++++++++++++++++++ > 2 files changed, 60 insertions(+), 2 deletions(-) > create mode 100644 test/tarantool-tests/gh-7264-add-proto-trace-sysprof-default.test.lua > <snipped> > -- > 2.36.1 > -- Best regards, IM
prev parent reply other threads:[~2022-11-11 9:07 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-12 18:52 Maxim Kokryashkin via Tarantool-patches 2022-06-16 6:56 ` Sergey Kaplun via Tarantool-patches 2022-07-04 15:27 ` Maxim Kokryashkin via Tarantool-patches 2022-07-15 13:36 ` Igor Munkin via Tarantool-patches 2022-11-11 8:54 ` Igor Munkin via Tarantool-patches [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=Y24NrWFKPbtsG6mU@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=imun@tarantool.org \ --cc=max.kokryashkin@gmail.com \ --subject='Re: [Tarantool-patches] [PATCH luajit] sysprof: disable proto and trace dumps in default' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox