From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id E21EE25D331; Tue, 14 Feb 2023 16:54:05 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E21EE25D331 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1676382846; bh=mZlv84/KGAZyfmc1sakZUPNPFThdI+AcKeNjnTF60Vk=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=YNh5WoXF7cb6SnVPF76Ub6vtEJP8TKfUdM+m+9trXlZs6lfx58RCZo96GNhSGhYKk iUmu+dbwrMrONfR2sfvCcfqh0yDDOwqB7COj3lMYScEoY+fT6abGiVgwFgUT/FEoZR 6cUBPJTJuj5DsV96iy/ICnxTIK//f79TSaISspaQ= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 44D8B25D32E for ; Tue, 14 Feb 2023 16:54:00 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 44D8B25D32E Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1pRvkt-0001gJ-JS; Tue, 14 Feb 2023 16:53:59 +0300 Date: Tue, 14 Feb 2023 16:50:27 +0300 To: Igor Munkin Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9806C989EC2150E3379A3C40B9AC0CB6A78DC697FD8BD72D3182A05F538085040EDEED619D80964E0F3B25A6E2BE33B8CBC25BC6EEE46F14EF10DA7B45AF740BC X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE71BDE6A359BD5B800EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637EA9DEEAA3ECF8E948638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D824F482683D891CA42DA9FBB8C3DFBC50117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCCD8DAA7A11EFD9E5A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520599709FD55CB46A62CC0D3CB04F14752D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6A45692FFBBD75A6A089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34AC6E62257D6CD1C9B4DD5F2B16751ACC709147BE5D1277F89897E99946F2377EBB8C3EFB924C04C91D7E09C32AA3244C39AA730E9B0B2230996AE8AA4783A94EFE8DA44ABE2443F7FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojgB/I+mAIlFETLXF3EszD7A== X-DA7885C5: BDB42F86D6C1F197DE6F6E25C01CBDF2E498CEE58F69639D02153A92A3AEF360262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F73933AF1F914F131DBF5582C3E49652E81C522149BC1A6DE8DA50FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 5/7] test: add skipcond for all JIT-related tests X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Igor! Thanks for the patch! LGTM. On 13.02.23, Igor Munkin wrote: > diff --git a/test/tarantool-tests/misclib-memprof-lapi.test.lua b/test/tarantool-tests/misclib-memprof-lapi.test.lua > index accb1ee1..e2701c13 100644 > --- a/test/tarantool-tests/misclib-memprof-lapi.test.lua > +++ b/test/tarantool-tests/misclib-memprof-lapi.test.lua > @@ -1,8 +1,6 @@ > -- XXX: This comment is a reminder to reimplement memprof tests > -- assertions to make them more indepentent to the changes made. > --- Now I just leave this 5 lines comment to preserve line numbers. > --- TODO: This line will be removed in the next patch. > --- TODO: This line will be removed in the next patch. > +-- Now I just leave this 3 lines comment to preserve line numbers. Side note: Still don't like this approach a lot, but, who cares. > local tap = require("tap") > local test = tap.test("misc-memprof-lapi"):skipcond({ > ["Memprof is implemented for x86_64 only"] = jit.arch ~= "x86" and > @@ -18,8 +16,10 @@ local jit_opt_default = { > "minstitch=0", > } > -- > 2.30.2 > -- Best regards, Sergey Kaplun