From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 89FA7258C8C; Mon, 13 Feb 2023 22:17:38 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 89FA7258C8C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1676315858; bh=RQflFP9CCxuGHk9EHDVqfR8ISIsx2vt14VYOsB0YZq4=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=DhSQbUcb0Tw7AmX0Xf1ELI8hBom0GauRZSlU+hFkoYcOdLtgfQc2vkIhGeENIFi9e ujPl/VfO/7/wsKRi6RsdA4x4ic3VkYrjEIz7IdMfa415dfBulpkOmInppFS6DyOgml Dt49AjzGrjb0ZNCu4+Q9T7DcaLfdVDRUafD7V99Y= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 085AA257FF1 for ; Mon, 13 Feb 2023 22:17:38 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 085AA257FF1 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1pReKX-0003Kx-8v; Mon, 13 Feb 2023 22:17:37 +0300 Date: Mon, 13 Feb 2023 22:14:05 +0300 To: Igor Munkin Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9806C989EC2150E3379A3C40B9AC0CB6A78DC697FD8BD72D3182A05F538085040C0BBB2C7B5D6EA099E6F2376375448008C245F60F429ED6E443B6C8C921BAA34 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7544B1CCE26E01C74EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063781BF90BB6B3E56078638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8772C14EC55CBECD9AE753E032D2012E7117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC93A51A5089774A2DA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735209647ADFADE5905B1F04B652EEC242312D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6AC294AFEFA671E80089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34D8FD11F74BDD6E8DE28F7BFB6DCF2BC2728092C12673BCD4ECB9898AC61E5EFF70D3E6E9F9D2E54D1D7E09C32AA3244C9777B8741AB58E1E31DAFC497282DD0060759606DA2E136AFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojgB/I+mAIlFGBnAyssuX+2g== X-DA7885C5: A1753608DD5ED4E0B2BA878F61CA3C09667185493240FC4930844515F0841EF8262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F73933AF1F914F131DBF58BF5DA02468A69F7817C9BC0AC3EE7AF0FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 7/7] ci: add nojit flavor for exotic builds X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Igor! Thanks for the patch! LGTM, except an ignorable suggestion. You've mentioned before offline that dualnum, checkhook entries are not sorted alphabetically. So, I suggest to sort these entries inside FLAVOR definition and sort FLAVORFLAGS definitions as well. Feel free to ignore. On 13.02.23, Igor Munkin wrote: > Since all testing machinery is adjusted for LuaJIT configuration with > disabled compiler support, the new flavor for exotic builds is > introduced in LuaJIT CI. > > Part of tarantool/tarantool#8252 > > Signed-off-by: Igor Munkin > --- > .github/workflows/exotic-builds-testing.yml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/.github/workflows/exotic-builds-testing.yml b/.github/workflows/exotic-builds-testing.yml > index 67ab9cc3..b28673c6 100644 > --- a/.github/workflows/exotic-builds-testing.yml > +++ b/.github/workflows/exotic-builds-testing.yml > @@ -36,7 +36,7 @@ jobs: > BUILDTYPE: [Debug, Release] > ARCH: [ARM64, x86_64] > GC64: [ON, OFF] > - FLAVOR: [dualnum, checkhook] > + FLAVOR: [dualnum, checkhook, nojit] > include: > - BUILDTYPE: Debug > CMAKEFLAGS: -DCMAKE_BUILD_TYPE=Debug -DLUA_USE_ASSERT=ON -DLUA_USE_APICHECK=ON > @@ -46,6 +46,8 @@ jobs: > FLAVORFLAGS: -DLUAJIT_NUMMODE=2 > - FLAVOR: checkhook > FLAVORFLAGS: -DLUAJIT_ENABLE_CHECKHOOK=ON > + - FLAVOR: nojit > + FLAVORFLAGS: -DLUAJIT_DISABLE_JIT=ON > exclude: > # DUALNUM is default for ARM64, no need for additional testing. > - FLAVOR: dualnum > -- > 2.30.2 > -- Best regards, Sergey Kaplun