From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id C0850257FF1; Mon, 13 Feb 2023 21:57:13 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C0850257FF1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1676314633; bh=epLaEjm1ehAOQ9sR5rR6JlgqXupXl3cFjkZwfSuf7Yc=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=wuKQ4QyhXVt58bVqKLZO35tj4N7OwFBGV+3gPb78Bx5BnMJNxGaBHnY+BFjuUPJ+D wDeAjoFAMWJFfzQpCsAAMhtv+wQ5cjtjYiUrOGuCczT2PU21NMJlRuMVxh5YTy686c 8+ws5DXQeJFAwCQuDYNGCOA7wj0bx7GVtoiW3vsE= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id CE31D257FF1 for ; Mon, 13 Feb 2023 21:57:12 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org CE31D257FF1 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1pRe0l-0004h9-W0; Mon, 13 Feb 2023 21:57:12 +0300 Date: Mon, 13 Feb 2023 21:53:40 +0300 To: Igor Munkin Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9806C989EC2150E337603B3C124283E76B43C8C11F7537CA8182A05F5380850409ABE33712D5A7DBF47C3039B4ECAB4D492BF9EC97F6B0AF62D30F8F46F94FC8B X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7051A6EFB787CE9C4EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006371E4BC0E00C009995EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38B6F1F7B995052D5CE6D1D48ED546CEC2AD5EF61CCD7FEB673CC7F00164DA146DAFE8445B8C89999728AA50765F7900637FBB89C51EA700D9A389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8CE4AEF6198D26326F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8B2303E78B907142AC75ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D345C110A855FC0999936BBE96BBC77F378D4927DF70C30DB7A158627408785901FDEC30803046E0EE71D7E09C32AA3244C1BE015CEB57C6512D6C79C31D297BDE3B038C9161EF167A1FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojgB/I+mAIlFHGzYJ83ZdgaA== X-DA7885C5: A1636060B6A51E4984E3CF58718B52392E65552D27B90AAFB5B8DA1B6FAB738D262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F73933AF1F914F131DBF525D5708B58F41399D6FD338893D051A70FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 2/7] build: fix build with JIT disabled X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Igor! Thanks for the patch! LGTM, except a single nit regarding the commit message. On 13.02.23, Igor Munkin wrote: > struct GCtrace is defined only if LJ_HASJIT is set. Hence all spots Typo: s/Hence,/Hence/ > where GCtrace is used should be also moved under LJ_HASJIT define. > > Relates to tarantool/tarantool#8252 Side note: I see "Relates" and "Related" in our commit logs, so I suggest to use "Relates" for future commits. > > Signed-off-by: Igor Munkin > -- > 2.30.2 > -- Best regards, Sergey Kaplun