From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 1139B21C253; Thu, 16 Feb 2023 10:01:53 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1139B21C253 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1676530913; bh=So/iXte64T1Q97uC35MTxAWuKq3F3u4+aVSBojwXDsI=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=krSImuB0AOtiuTAVjP+nkShEg1bfFqVCIPc1QSgpx/qo/9Y5o9daEkBeJ0Z+I6pxq 0i1KlTTxDX6a6W1GfLksOVo3aI+sOHTycv6YT7d8yBT7dGt5OmVZ1VB4fY1TWAKMec 0TgM5PtOYfeXE5mqnOl+/UntKorWnwCBQ3MDK5TI= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 39BC921C253 for ; Thu, 16 Feb 2023 10:01:52 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 39BC921C253 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1pSYH9-0008AI-ID; Thu, 16 Feb 2023 10:01:51 +0300 Date: Thu, 16 Feb 2023 09:58:19 +0300 To: Maxim Kokryashkin Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD94A31EA4B0797EF2EBEF8AA50000CB2E0FF25F7F485B287F1182A05F5380850404C228DA9ACA6FE277649BB061E44C7BC62C57702A388A95523EE173135EEDCAF021B7F27C9D7C6A9 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE716FAD50E497B9C14EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006378BCFB34D7DDF138E8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D824AC7D0B0A7E7AE6CC094699A69EE837117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCDBA3F3F673D6AB81A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735204B6963042765DA4BBDFBBEFFF4125B51D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6A45692FFBBD75A6A089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34C1E32F4AD4B2486BE949A81B578C369CDD1E479AC2282517A389FEBF26AC4D7D78932C0998349AA21D7E09C32AA3244C875124ECDF65C540393A1D0287EBA61F725D5B54B2FE4575FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojohRiI5imL48ZOFMZjT11Ww== X-DA7885C5: 0A51F4D4F7BD0BA083A48F6BB38B97E7AA4FB690FD81765C18057CF04A47F731262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F73933AF1F914F131DBF50F435FD38379835ADFDAFD23D0E5A11C0FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 3/5] Disable unreliable assertion for external frame unwinding. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! Thanks for the patch! LGTM, except a few comments below. On 15.02.23, Maxim Kokryashkin wrote: > From: Mike Pall > > Broken on Fedora/ARM64. Reported by Yichun Zhang. > > (cherry-picked from commit e957737650e060d5bf1c2909b741cc3dffe073ac) > > This patch disables the assertion that failed because of > incorrectly constructed unwind information. > That debug info generation was fixed in the scope > of tarantool/tarantool#6096. This patch is backported > only for consistency. > I suggest to menion the commit directly: b731df1c0392cf7008be2e3c4112e1edb2392de4 ("ARM64: Reorder interpreter stack frame and fix unwinding.") NB: I mention _our_ commit intense -- so we can follow this commit chain in our repo and cherry-picked notes link commits to the upstream. > Maxim Kokryashkin: > * added the description for the problem > > Part of tarantool/tarantool#7745 > Relates to tarantool/tarantool#6096 I suppose that we should add: | Part of tarantool/tarantool#8069 > --- > src/lj_err.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/lj_err.c b/src/lj_err.c > index c7fd9e65..f6200233 100644 > --- a/src/lj_err.c > +++ b/src/lj_err.c > @@ -488,7 +488,9 @@ void lj_err_verify(void) > ** lj_assertX(_Unwind_Find_FDE((void *)_Unwind_RaiseException, &ehb), "broken build: external frame unwinding enabled, but system libraries have no unwind tables"); > */ > lua_assert(_Unwind_Find_FDE((void *)lj_err_throw, &ehb)); > + /* Check disabled, because of broken Fedora/ARM64. See #722. I see that this line is present in LuaJIT's master. Should it be removed as far as this issue is resolved? > lua_assert(_Unwind_Find_FDE((void *)_Unwind_RaiseException, &ehb)); > + */ > } > #endif > > -- > 2.39.0 > -- Best regards, Sergey Kaplun